Skip to content

Conversation

@danpospisil
Copy link
Contributor

@danpospisil danpospisil commented Jan 31, 2021

fix #2136

Proposed changes

This PR is adding support for HEAD HTTP method for all GET routes back to v5 as discussed here: adonisjs/core#2136 (comment)
Tests are modified as well

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@thetutlage thetutlage merged commit 05c00a2 into adonisjs:develop Feb 3, 2021
@thetutlage
Copy link
Member

Looks good. Thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants