Skip to content

fix(router): adding support for HEAD HTTP method for all GET routes back to v5 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021
Merged

fix(router): adding support for HEAD HTTP method for all GET routes back to v5 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion npm-audit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ <h5 class="card-title">
<div class="card">
<div class="card-body">
<h5 class="card-title">
November 24th 2020, 7:06:37 pm
January 31st 2021, 6:53:36 pm
</h5>
<p class="card-text">Last updated</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/Router/BriskRoute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class BriskRoute extends Macroable implements BriskRouteContract {
)
}

this.route = new Route(this.pattern, methods || ['GET'], handler, this.globalMatchers)
this.route = new Route(this.pattern, methods || ['HEAD', 'GET'], handler, this.globalMatchers)
this.invokedBy = invokedBy
return this.route
}
Expand Down
8 changes: 4 additions & 4 deletions src/Router/Resource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ export class RouteResource extends Macroable implements RouteResourceContract {
.map((token) => `${token}/:${lodash.snakeCase(singular(token))}_id`)
.join('/')}/${mainResource}`

this.makeRoute(fullUrl, ['GET'], 'index')
this.makeRoute(`${fullUrl}/create`, ['GET'], 'create')
this.makeRoute(fullUrl, ['HEAD', 'GET'], 'index')
this.makeRoute(`${fullUrl}/create`, ['HEAD', 'GET'], 'create')
this.makeRoute(fullUrl, ['POST'], 'store')
this.makeRoute(`${this.shallow ? mainResource : fullUrl}/:id`, ['GET'], 'show')
this.makeRoute(`${this.shallow ? mainResource : fullUrl}/:id/edit`, ['GET'], 'edit')
this.makeRoute(`${this.shallow ? mainResource : fullUrl}/:id`, ['HEAD', 'GET'], 'show')
this.makeRoute(`${this.shallow ? mainResource : fullUrl}/:id/edit`, ['HEAD', 'GET'], 'edit')
this.makeRoute(`${this.shallow ? mainResource : fullUrl}/:id`, ['PUT', 'PATCH'], 'update')
this.makeRoute(`${this.shallow ? mainResource : fullUrl}/:id`, ['DELETE'], 'destroy')
}
Expand Down
2 changes: 1 addition & 1 deletion src/Router/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export class Router implements RouterContract {
* Define `GET` route
*/
public get(pattern: string, handler: RouteHandler): Route {
return this.route(pattern, ['GET'], handler)
return this.route(pattern, ['HEAD', 'GET'], handler)
}

/**
Expand Down
2 changes: 1 addition & 1 deletion test/brisk-route.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test.group('Brisk Route', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
middleware: [],
name: undefined,
pattern: '/',
Expand Down
16 changes: 8 additions & 8 deletions test/group.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.index',
Expand All @@ -157,7 +157,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.create',
Expand All @@ -181,7 +181,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.show',
Expand All @@ -193,7 +193,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.edit',
Expand Down Expand Up @@ -238,7 +238,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.index',
Expand All @@ -250,7 +250,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.create',
Expand All @@ -274,7 +274,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.show',
Expand All @@ -286,7 +286,7 @@ test.group('Route Group', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.edit',
Expand Down
48 changes: 24 additions & 24 deletions test/resource.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.index',
Expand All @@ -35,7 +35,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.create',
Expand All @@ -59,7 +59,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.show',
Expand All @@ -71,7 +71,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.edit',
Expand Down Expand Up @@ -117,7 +117,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.index',
Expand All @@ -129,7 +129,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.create',
Expand All @@ -153,7 +153,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.show',
Expand All @@ -165,7 +165,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.edit',
Expand Down Expand Up @@ -211,7 +211,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.index',
Expand All @@ -223,7 +223,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.create',
Expand All @@ -247,7 +247,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.show',
Expand All @@ -259,7 +259,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'AdsController.edit',
Expand Down Expand Up @@ -436,7 +436,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.index',
Expand All @@ -448,7 +448,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.create',
Expand All @@ -472,7 +472,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.show',
Expand All @@ -484,7 +484,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'PhotosController.edit',
Expand Down Expand Up @@ -530,7 +530,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'ProfileController.index',
Expand All @@ -542,7 +542,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'ProfileController.create',
Expand All @@ -566,7 +566,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'ProfileController.show',
Expand All @@ -578,7 +578,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'ProfileController.edit',
Expand Down Expand Up @@ -624,7 +624,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'CommentsController.index',
Expand All @@ -636,7 +636,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'CommentsController.create',
Expand All @@ -660,7 +660,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'CommentsController.show',
Expand All @@ -672,7 +672,7 @@ test.group('Route Resource', () => {
meta: {
namespace: undefined,
},
methods: ['GET'],
methods: ['HEAD', 'GET'],
domain: 'root',
middleware: [],
handler: 'CommentsController.edit',
Expand Down
Loading