Add aws auth for xds#280
Merged
Merged
Conversation
Signed-off-by: npolshakova <nina.polshakova@solo.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements AWS authentication support for XDS (Extensible Discovery Service) by expanding the AWS backend authentication configuration to include credential fields. The change moves from an empty AWS auth struct to one that supports access keys, regions, and session tokens for AWS service authentication.
- Updates protobuf definition to include AWS credential fields (access_key_id, secret_access_key, region, service, session_token)
- Modifies Rust backend authentication types to handle the new AWS credential structure
- Updates AWS authentication handling logic to use the new credential fields
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
proto/resource.proto |
Adds AWS credential fields to the protobuf message definition |
src/types/agent_xds.rs |
Updates conversion logic to map protobuf AWS auth fields to Rust types |
src/http/auth.rs |
Expands BackendAuth::Aws enum variant to include credential fields |
src/llm/mod.rs |
Updates Bedrock provider to use new AWS auth structure with placeholder credentials |
Signed-off-by: npolshakova <nina.polshakova@solo.io>
howardjohn
reviewed
Aug 6, 2025
Signed-off-by: npolshakova <nina.polshakova@solo.io>
npolshakova
commented
Aug 7, 2025
howardjohn
reviewed
Aug 7, 2025
howardjohn
reviewed
Aug 8, 2025
| "type": "object", | ||
| "properties": { | ||
| "file": { | ||
| "access_key_id": { |
Collaborator
There was a problem hiding this comment.
This needs the camelCase directive on the Explicit enum; you can see it didn't get set so its snake case here
Signed-off-by: npolshakova <nina.polshakova@solo.io>
howardjohn
approved these changes
Aug 8, 2025
surinderunitone
pushed a commit
to UnitOneAI/agentgateway
that referenced
this pull request
Feb 1, 2026
* add aws auth for xds Signed-off-by: npolshakova <nina.polshakova@solo.io> * add go types Signed-off-by: npolshakova <nina.polshakova@solo.io> * remove service for now Signed-off-by: npolshakova <nina.polshakova@solo.io> * add implicit aws config opt * add provider name to config builder * regen Signed-off-by: npolshakova <nina.polshakova@solo.io> * fix camel case Signed-off-by: npolshakova <nina.polshakova@solo.io> * gen --------- Signed-off-by: npolshakova <nina.polshakova@solo.io> Co-authored-by: John Howard <john.howard@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit aws auth config for xds. Tested with kgateway: kgateway-dev/kgateway#11899