docs(greenfield): remove per-story evidence pins - #109
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThe update removes per-story ChangesGreenfield delivery contract
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
scripts/check-delivery-track.mjs (1)
939-939: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDerive the diagnostic count from
STORY_KEYS.These messages repeat the literal
15; useSTORY_KEYS.lengthinstead so future schema changes cannot leave validation and diagnostics inconsistent.Proposed refactor
- if (!exactKeys(story, STORY_KEYS)) errors.push(`${story.id} must have exactly the 15 story fields`); + if (!exactKeys(story, STORY_KEYS)) + errors.push(`${story.id} must have exactly the ${STORY_KEYS.length} story fields`); - errors.push(`${story.id} front matter must use exactly the 15 canonical fields`); + errors.push(`${story.id} front matter must use exactly the ${STORY_KEYS.length} canonical fields`); - errors.push(`${story.id} front matter must exactly match all 15 track fields`); + errors.push(`${story.id} front matter must exactly match all ${STORY_KEYS.length} track fields`);Also applies to: 1044-1046
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/check-delivery-track.mjs` at line 939, Update the diagnostic messages in the story validation logic, including the locations around the exact-key check and lines 1044-1046, to derive the reported field count from STORY_KEYS.length instead of the literal 15. Keep the existing validation behavior and message context unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/delivery/greenfield/delivery-policy.md`:
- Around line 136-143: Revise Rule 16 to prohibit only delivery-process
provenance/assertion state and generated evidence identifiers, not all story IDs
or branch references. Explicitly exempt canonical story paths such as the
story_file field and docs/delivery/greenfield/stories/GF-*.md, along with
ordinary repository and CI configuration, while preserving restrictions on
committed delivery state artifacts.
---
Nitpick comments:
In `@scripts/check-delivery-track.mjs`:
- Line 939: Update the diagnostic messages in the story validation logic,
including the locations around the exact-key check and lines 1044-1046, to
derive the reported field count from STORY_KEYS.length instead of the literal
15. Keep the existing validation behavior and message context unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 717ca262-adfc-4973-9d48-c8ff9d9638d6
📒 Files selected for processing (55)
docs/delivery/greenfield/delivery-policy.mddocs/delivery/greenfield/reviewer/review-checklist.mddocs/delivery/greenfield/stories/GF-001.mddocs/delivery/greenfield/stories/GF-002.mddocs/delivery/greenfield/stories/GF-003.mddocs/delivery/greenfield/stories/GF-004.mddocs/delivery/greenfield/stories/GF-005.mddocs/delivery/greenfield/stories/GF-010.mddocs/delivery/greenfield/stories/GF-011.mddocs/delivery/greenfield/stories/GF-012.mddocs/delivery/greenfield/stories/GF-013.mddocs/delivery/greenfield/stories/GF-014.mddocs/delivery/greenfield/stories/GF-015.mddocs/delivery/greenfield/stories/GF-019.mddocs/delivery/greenfield/stories/GF-020.mddocs/delivery/greenfield/stories/GF-021.mddocs/delivery/greenfield/stories/GF-022.mddocs/delivery/greenfield/stories/GF-023.mddocs/delivery/greenfield/stories/GF-024.mddocs/delivery/greenfield/stories/GF-025.mddocs/delivery/greenfield/stories/GF-026.mddocs/delivery/greenfield/stories/GF-030.mddocs/delivery/greenfield/stories/GF-031.mddocs/delivery/greenfield/stories/GF-032.mddocs/delivery/greenfield/stories/GF-033.mddocs/delivery/greenfield/stories/GF-034.mddocs/delivery/greenfield/stories/GF-035.mddocs/delivery/greenfield/stories/GF-036.mddocs/delivery/greenfield/stories/GF-037.mddocs/delivery/greenfield/stories/GF-038.mddocs/delivery/greenfield/stories/GF-039.mddocs/delivery/greenfield/stories/GF-040.mddocs/delivery/greenfield/stories/GF-041.mddocs/delivery/greenfield/stories/GF-042.mddocs/delivery/greenfield/stories/GF-043.mddocs/delivery/greenfield/stories/GF-044.mddocs/delivery/greenfield/stories/GF-045.mddocs/delivery/greenfield/stories/GF-046.mddocs/delivery/greenfield/stories/GF-047.mddocs/delivery/greenfield/stories/GF-050.mddocs/delivery/greenfield/stories/GF-051.mddocs/delivery/greenfield/stories/GF-052.mddocs/delivery/greenfield/stories/GF-053.mddocs/delivery/greenfield/stories/GF-054.mddocs/delivery/greenfield/stories/GF-055.mddocs/delivery/greenfield/stories/GF-056.mddocs/delivery/greenfield/stories/GF-057.mddocs/delivery/greenfield/stories/GF-060.mddocs/delivery/greenfield/stories/GF-061.mddocs/delivery/greenfield/stories/GF-062.mddocs/delivery/greenfield/story-contract.mddocs/delivery/greenfield/track.jsondocs/delivery/greenfield/verification.mdscripts/check-delivery-track.mjsscripts/check-delivery-track.test.mjs
💤 Files with no reviewable changes (32)
- docs/delivery/greenfield/stories/GF-013.md
- docs/delivery/greenfield/stories/GF-020.md
- docs/delivery/greenfield/stories/GF-003.md
- docs/delivery/greenfield/stories/GF-026.md
- docs/delivery/greenfield/stories/GF-002.md
- docs/delivery/greenfield/stories/GF-022.md
- docs/delivery/greenfield/stories/GF-050.md
- docs/delivery/greenfield/stories/GF-025.md
- docs/delivery/greenfield/stories/GF-055.md
- docs/delivery/greenfield/stories/GF-062.md
- docs/delivery/greenfield/stories/GF-046.md
- docs/delivery/greenfield/stories/GF-019.md
- docs/delivery/greenfield/stories/GF-040.md
- docs/delivery/greenfield/stories/GF-061.md
- docs/delivery/greenfield/stories/GF-023.md
- docs/delivery/greenfield/stories/GF-051.md
- docs/delivery/greenfield/stories/GF-021.md
- docs/delivery/greenfield/stories/GF-010.md
- docs/delivery/greenfield/stories/GF-004.md
- docs/delivery/greenfield/stories/GF-043.md
- docs/delivery/greenfield/stories/GF-047.md
- docs/delivery/greenfield/stories/GF-030.md
- docs/delivery/greenfield/stories/GF-045.md
- docs/delivery/greenfield/stories/GF-037.md
- docs/delivery/greenfield/stories/GF-057.md
- docs/delivery/greenfield/stories/GF-036.md
- docs/delivery/greenfield/stories/GF-044.md
- docs/delivery/greenfield/stories/GF-035.md
- docs/delivery/greenfield/stories/GF-041.md
- docs/delivery/greenfield/stories/GF-011.md
- docs/delivery/greenfield/stories/GF-001.md
- docs/delivery/greenfield/track.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baseline_commitand make exact-subject evidence a retained CI artifact.Unblocks: rework of #108 under the amended policy.
Verification
pnpm install --frozen-lockfilepnpm delivery:checkpnpm checkgit diff --checkgrep -rn 'baseline_commit' docs/delivery/ scripts/ | wc -l→0The delivery validator passed for 48 stories and 7 phases and emitted an unpinned candidate-package manifest digest. The approved normative-corpus and story-authority-binding digest constants are unchanged.
Out of scope
feat/greenfield-phase-0-substrate, or its worktree atworktrees/jig/feat-greenfield-phase-0-substrate. A separate PR reworks it after this one merges.scripts/run-gf-001-tests.mjs,scripts/write-gf-001-evidence.mjs,tests/gf-001/, ortests/fixtures/gf-001-workspace/. They are onmainand are PR 2's job — removing them here would breakpnpm checkon this branch..github/workflows/check.yml. PR 2 owns it.docs/product/,docs/redesign/, or anything else in the 67-file normative corpus — it would move an approved digest.DR-*selections. Onlybaseline_commitleaves.Summary by CodeRabbit
Documentation
baseline_commitfrom story documentation and updated related start-evidence explanations.Validation