Skip to content

feat(users): add users proto#34

Merged
vitramir merged 6 commits intomainfrom
noa/issue-1
Mar 20, 2026
Merged

feat(users): add users proto#34
vitramir merged 6 commits intomainfrom
noa/issue-1

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • add users service proto definitions

Testing

  • buf lint
  • buf build

Refs #1

@casey-brooks casey-brooks requested a review from a team as a code owner March 19, 2026 19:58
@github-actions
Copy link

github-actions bot commented Mar 19, 2026

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 19, 2026, 11:37 PM

@casey-brooks
Copy link
Contributor Author

Test & Lint Summary

  • buf lint (no errors)
  • buf build (no errors)

@rowan-stein
Copy link
Collaborator

Review Request

This PR adds the Users service proto definition (proto/agynio/api/users/v1/users.proto) as part of the new Users service implementation tracked in agynio/users#1.

CI is green — buf lint and build pass.

This PR is a prerequisite for the users service implementation PR (agynio/users#2) — after merge, the buf-publish workflow will push the updated module to BSR, enabling the service to generate its Go bindings.

Related PRs:

noa-lucent
noa-lucent previously approved these changes Mar 19, 2026
Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto definition is clean and matches the spec exactly. All 5 RPCs, message types, EntityMeta wrapper, optional fields on UpdateUserRequest, and Go package path all follow established patterns.

@casey-brooks
Copy link
Contributor Author

Summary:

  • Renamed users proto nickname fields to email.

Checks:

  • buf lint
  • buf build
  • $(npm config get prefix)/bin/redocly bundle openapi/team/v1/openapi.yaml -o dist/team-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/files/v1/openapi.yaml -o dist/files-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/llm/v1/openapi.yaml -o dist/llm-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/team-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/files-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/llm-v1.yaml

Tests: passed: 0, failed: 0, skipped: 0.
Lint: buf lint no errors; spectral lint warnings about missing info contact/description and operation description/operationId (no errors).

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nicknameemail rename in users.proto is clean — field numbers preserved, all three messages updated consistently.

However, this PR now includes an unrelated tenants.proto file that wasn't in the original scope. Please split it out or update the PR scope accordingly.

@casey-brooks
Copy link
Contributor Author

Summary:

  • Removed the unrelated tenants proto from the users PR branch.

Checks:

  • buf lint
  • buf build
  • $(npm config get prefix)/bin/redocly bundle openapi/team/v1/openapi.yaml -o dist/team-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/files/v1/openapi.yaml -o dist/files-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/llm/v1/openapi.yaml -o dist/llm-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/team-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/files-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/llm-v1.yaml

Tests: passed: 0, failed: 0, skipped: 0.
Lint: buf lint no errors; spectral lint warnings about missing info contact/description and operation description/operationId (no errors).

noa-lucent
noa-lucent previously approved these changes Mar 19, 2026
Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out-of-scope tenants.proto removed. PR now contains only users.proto as intended. Prior thread resolved. Approving.

@casey-brooks casey-brooks dismissed noa-lucent’s stale review March 19, 2026 23:40

The merge-base changed after approval.

vitramir
vitramir previously approved these changes Mar 20, 2026
@casey-brooks casey-brooks dismissed vitramir’s stale review March 20, 2026 00:16

The merge-base changed after approval.

@vitramir vitramir merged commit cc5be95 into main Mar 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants