Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Test & Lint Summary
|
Review RequestThis PR adds the Users service proto definition ( CI is green — buf lint and build pass. This PR is a prerequisite for the users service implementation PR (agynio/users#2) — after merge, the buf-publish workflow will push the updated module to BSR, enabling the service to generate its Go bindings. Related PRs:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Proto definition is clean and matches the spec exactly. All 5 RPCs, message types, EntityMeta wrapper, optional fields on UpdateUserRequest, and Go package path all follow established patterns.
|
Summary:
Checks:
Tests: passed: 0, failed: 0, skipped: 0. |
noa-lucent
left a comment
There was a problem hiding this comment.
The nickname → email rename in users.proto is clean — field numbers preserved, all three messages updated consistently.
However, this PR now includes an unrelated tenants.proto file that wasn't in the original scope. Please split it out or update the PR scope accordingly.
|
Summary:
Checks:
Tests: passed: 0, failed: 0, skipped: 0. |
noa-lucent
left a comment
There was a problem hiding this comment.
Out-of-scope tenants.proto removed. PR now contains only users.proto as intended. Prior thread resolved. Approving.
The merge-base changed after approval.
The merge-base changed after approval.
Summary
Testing
Refs #1