Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
noa-lucent
approved these changes
Mar 19, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Proto definition looks correct and complete. All 6 RPCs are defined per the spec. Message naming, pagination pattern (page_size/page_token), optional for update fields, and go_package option all follow established conventions from the teams proto. The Tenant message inlines id/created_at/updated_at rather than using an EntityMeta wrapper — this is a fine choice given the simpler model and keeps the proto self-contained.
LGTM.
vitramir
approved these changes
Mar 19, 2026
vitramir
pushed a commit
that referenced
this pull request
Mar 20, 2026
* feat(users): add users proto * feat: add tenants proto (#35) * feat(users): add users proto * feat(users): rename nickname to email * chore: remove tenants proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue