Centralize console E2E tests#79
Conversation
|
Summary:
Tests:
|
4eea66f to
bd74e33
Compare
|
Summary:
Tests:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Looks aligned with #71: local Playwright E2E + DevSpace e2e-runner plumbing removed, and CI E2E job now uses bootstrap provision + centralized e2e actions with service: console.
Left two minor notes inline (pin @bufbuild/buf, and prune the lockfile to actually drop Playwright/Argos packages).
(Static review only — not executed locally.)
| }, | ||
| "devDependencies": { | ||
| "@argos-ci/playwright": "^6.6.1", | ||
| "@bufbuild/buf": "latest", |
There was a problem hiding this comment.
[minor] @bufbuild/buf is set to "latest". Even with a lockfile, this is easy to accidentally upgrade and can change generated output over time. Prefer pinning an explicit version (and letting the lockfile follow) for CI determinism.
| @@ -30,12 +30,10 @@ | |||
| "tw-animate-css": "^1.4.0" | |||
| }, | |||
| "devDependencies": { | |||
There was a problem hiding this comment.
[minor] package-lock.json still contains large blocks for removed Playwright/Argos deps (e.g. node_modules/@playwright/test, node_modules/playwright, node_modules/@argos-ci/playwright).
Since the local e2e suite is being removed, it’d be good to regenerate/prune the lockfile so those packages are actually dropped (keeps the lockfile honest and avoids unnecessary installs/security scan noise).
* feat(workloads): add detail view * refactor(e2e): centralize console tests (#79) * fix(workloads): refine log viewer
* feat(workloads): add detail view * refactor(e2e): centralize console tests (#79) * fix(workloads): refine log viewer
Summary
Testing
Closes #71