Skip to content

Centralize console E2E tests#79

Merged
rowan-stein merged 1 commit into
mainfrom
noa/issue-71
Apr 23, 2026
Merged

Centralize console E2E tests#79
rowan-stein merged 1 commit into
mainfrom
noa/issue-71

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • switch CI E2E job to bootstrap provision + e2e composite actions with the console service tag
  • remove local Playwright e2e suite and DevSpace e2e-runner plumbing
  • drop Playwright config/script and simplify vitest excludes

Testing

  • npm run generate
  • npm run lint
  • npm test
  • npm run typecheck

Closes #71

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary:

  • switched the CI e2e job to bootstrap provision + e2e composite actions with the console service tag
  • removed local Playwright e2e suite and DevSpace e2e-runner plumbing
  • dropped the Playwright config/script and simplified vitest excludes

Tests:

  • npm run generate
  • npm run lint (no issues)
  • npm test (passed: 56, failed: 0, skipped: 0)
  • npm run typecheck

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary:

Tests:

  • npm run generate
  • npm run lint (no issues)
  • npm test (passed: 60, failed: 0, skipped: 0)
  • npm run typecheck

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks aligned with #71: local Playwright E2E + DevSpace e2e-runner plumbing removed, and CI E2E job now uses bootstrap provision + centralized e2e actions with service: console.

Left two minor notes inline (pin @bufbuild/buf, and prune the lockfile to actually drop Playwright/Argos packages).

(Static review only — not executed locally.)

Comment thread package.json
},
"devDependencies": {
"@argos-ci/playwright": "^6.6.1",
"@bufbuild/buf": "latest",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] @bufbuild/buf is set to "latest". Even with a lockfile, this is easy to accidentally upgrade and can change generated output over time. Prefer pinning an explicit version (and letting the lockfile follow) for CI determinism.

Comment thread package-lock.json
@@ -30,12 +30,10 @@
"tw-animate-css": "^1.4.0"
},
"devDependencies": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] package-lock.json still contains large blocks for removed Playwright/Argos deps (e.g. node_modules/@playwright/test, node_modules/playwright, node_modules/@argos-ci/playwright).

Since the local e2e suite is being removed, it’d be good to regenerate/prune the lockfile so those packages are actually dropped (keeps the lockfile honest and avoids unnecessary installs/security scan noise).

@rowan-stein
rowan-stein merged commit ae86e8e into main Apr 23, 2026
2 checks passed
rowan-stein pushed a commit that referenced this pull request Apr 23, 2026
* feat(workloads): add detail view

* refactor(e2e): centralize console tests (#79)

* fix(workloads): refine log viewer
casey-brooks added a commit that referenced this pull request Apr 23, 2026
* feat(workloads): add detail view

* refactor(e2e): centralize console tests (#79)

* fix(workloads): refine log viewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to centralized E2E (remove local Playwright e2e + update CI)

3 participants