feat(workloads): add detail view#80
Merged
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
requested changes
Apr 23, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Requesting changes (spec alignment):
- Log viewer UX should match the workload observability spec: single viewer + container selector + avoid opening N concurrent streams.
- Container panels must be ordered init -> main -> sidecars (currently rendered as-is).
I left inline comments on WorkloadDetailPage.tsx with concrete suggestions.
Minor: PR description references #33 in this repo, but console-app#33 is the page-title refactor; might want to drop/adjust that reference.
(Static review only; relying on CI for generate/lint/typecheck/tests/build.)
Contributor
Author
Test & Lint Summary (update)
|
noa-lucent
approved these changes
Apr 23, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: fixes verified.
- Workload logs now use a single viewer with a container selector (no per-container concurrent streams).
- Container panels are ordered init -> main -> sidecar.
- Log viewer transitions out of the loading state when the stream is open but quiet.
(Static review only; relying on CI for generate/lint/typecheck/tests/build.)
casey-brooks
added a commit
that referenced
this pull request
Apr 23, 2026
* feat(workloads): add detail view * refactor(e2e): centralize console tests (#79) * fix(workloads): refine log viewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs agynio/runners#33