Skip to content

Test2 Merging developments to integrate Grid2op + Graph Print API + mode manuel + mode agent - #6

Merged
marota merged 6 commits into
ainetus:masterfrom
mjothy:master
Jul 15, 2020
Merged

Test2 Merging developments to integrate Grid2op + Graph Print API + mode manuel + mode agent#6
marota merged 6 commits into
ainetus:masterfrom
mjothy:master

Conversation

@marota

@marota marota commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@marota
marota merged commit 99f8b7f into ainetus:master Jul 15, 2020
marota pushed a commit to marota/ExpertOp4Grid_marota that referenced this pull request Jul 16, 2026
Feuille de route des pistes restantes (open findings ainetus#4/ainetus#6/ainetus#7, CI static-analysis
repoint, mixins->composition, interactive_html/Grid2opSimulation decomposition,
model-vs-colour inversion, AlphaDeesp run() API, naming aliases, grid2op CI
validation + release/bump).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ
marota pushed a commit to marota/ExpertOp4Grid_marota that referenced this pull request Jul 16, 2026
…aph, create_df, shortest paths, interactive_html split

Deep revisions:
- Model/colour inversion: new graphs/edge_roles.py (edge_role_of / base_color_of
  / EDGE_ROLE_*). tag_constrained_path reads the semantic role instead of parsing
  the Graphviz colour string; highlight_significant_line_loading records an
  authoritative base_color when it wraps a colour into the compound "c:yellow:c";
  new OverFlowGraph.edge_role(name). Exported via the package + shim.
- AlphaDeesp.__init__ -> explicit run(): the ranking pipeline moved into run();
  auto_run=True (default) preserves backwards-compatible construction; results
  are initialised empty so auto_run=False builds a well-formed, un-run object.
- Structured_Overload_Distribution_Graph: colour-filtered views, red_loops and
  hubs are now functools.cached_property (constrained path stays eager). red_loops
  uses the constructor seed hubs; public find_loops() uses the detected hubs — this
  split makes the lazy properties order-independent while matching the old eager
  behaviour exactly.

Open findings:
- ainetus#4 create_df: vectorised the iterrows passes with numpy masks; ltc_report now
  uses positional .iloc. Behaviour pinned by a 400-case differential fuzz against
  a faithful re-implementation of the original loop.
- ainetus#6 shortest_paths.py: shared _make_incentivized_weight, multigraph-correct
  (min parallel weight + (u,v)/(u,v,key) promoted matching); dead branch removed.
- ainetus#7 to_DiGraph: a missing capacity now defaults to 0.0 (neutral in the min-cut)
  instead of a spurious 1.0.

Maintainability:
- interactive_html.py (976 LOC) -> package interactive_html/ (8 focused modules)
  with the CSS/JS/HTML skeleton externalised under assets/ and reassembled
  byte-exactly at runtime; shipped via package_data + MANIFEST.in.

Docs: CLAUDE.md and docs/CODE_REVIEW.md updated. All graph-package / ranking /
renderer / create_df / interactive-html unit suites pass (367) without grid2op.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ
marota pushed a commit to marota/ExpertOp4Grid_marota that referenced this pull request Jul 16, 2026
Feuille de route des pistes restantes (open findings ainetus#4/ainetus#6/ainetus#7, CI static-analysis
repoint, mixins->composition, interactive_html/Grid2opSimulation decomposition,
model-vs-colour inversion, AlphaDeesp run() API, naming aliases, grid2op CI
validation + release/bump).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ
Signed-off-by: Antoine Marot <amarot91@gmail.com>
marota pushed a commit to marota/ExpertOp4Grid_marota that referenced this pull request Jul 16, 2026
…aph, create_df, shortest paths, interactive_html split

Deep revisions:
- Model/colour inversion: new graphs/edge_roles.py (edge_role_of / base_color_of
  / EDGE_ROLE_*). tag_constrained_path reads the semantic role instead of parsing
  the Graphviz colour string; highlight_significant_line_loading records an
  authoritative base_color when it wraps a colour into the compound "c:yellow:c";
  new OverFlowGraph.edge_role(name). Exported via the package + shim.
- AlphaDeesp.__init__ -> explicit run(): the ranking pipeline moved into run();
  auto_run=True (default) preserves backwards-compatible construction; results
  are initialised empty so auto_run=False builds a well-formed, un-run object.
- Structured_Overload_Distribution_Graph: colour-filtered views, red_loops and
  hubs are now functools.cached_property (constrained path stays eager). red_loops
  uses the constructor seed hubs; public find_loops() uses the detected hubs — this
  split makes the lazy properties order-independent while matching the old eager
  behaviour exactly.

Open findings:
- ainetus#4 create_df: vectorised the iterrows passes with numpy masks; ltc_report now
  uses positional .iloc. Behaviour pinned by a 400-case differential fuzz against
  a faithful re-implementation of the original loop.
- ainetus#6 shortest_paths.py: shared _make_incentivized_weight, multigraph-correct
  (min parallel weight + (u,v)/(u,v,key) promoted matching); dead branch removed.
- ainetus#7 to_DiGraph: a missing capacity now defaults to 0.0 (neutral in the min-cut)
  instead of a spurious 1.0.

Maintainability:
- interactive_html.py (976 LOC) -> package interactive_html/ (8 focused modules)
  with the CSS/JS/HTML skeleton externalised under assets/ and reassembled
  byte-exactly at runtime; shipped via package_data + MANIFEST.in.

Docs: CLAUDE.md and docs/CODE_REVIEW.md updated. All graph-package / ranking /
renderer / create_df / interactive-html unit suites pass (367) without grid2op.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ
Signed-off-by: Antoine Marot <amarot91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants