Test2 Merging developments to integrate Grid2op + Graph Print API + mode manuel + mode agent - #6
Merged
Merged
Conversation
marota
pushed a commit
to marota/ExpertOp4Grid_marota
that referenced
this pull request
Jul 16, 2026
Feuille de route des pistes restantes (open findings ainetus#4/ainetus#6/ainetus#7, CI static-analysis repoint, mixins->composition, interactive_html/Grid2opSimulation decomposition, model-vs-colour inversion, AlphaDeesp run() API, naming aliases, grid2op CI validation + release/bump). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ
marota
pushed a commit
to marota/ExpertOp4Grid_marota
that referenced
this pull request
Jul 16, 2026
…aph, create_df, shortest paths, interactive_html split Deep revisions: - Model/colour inversion: new graphs/edge_roles.py (edge_role_of / base_color_of / EDGE_ROLE_*). tag_constrained_path reads the semantic role instead of parsing the Graphviz colour string; highlight_significant_line_loading records an authoritative base_color when it wraps a colour into the compound "c:yellow:c"; new OverFlowGraph.edge_role(name). Exported via the package + shim. - AlphaDeesp.__init__ -> explicit run(): the ranking pipeline moved into run(); auto_run=True (default) preserves backwards-compatible construction; results are initialised empty so auto_run=False builds a well-formed, un-run object. - Structured_Overload_Distribution_Graph: colour-filtered views, red_loops and hubs are now functools.cached_property (constrained path stays eager). red_loops uses the constructor seed hubs; public find_loops() uses the detected hubs — this split makes the lazy properties order-independent while matching the old eager behaviour exactly. Open findings: - ainetus#4 create_df: vectorised the iterrows passes with numpy masks; ltc_report now uses positional .iloc. Behaviour pinned by a 400-case differential fuzz against a faithful re-implementation of the original loop. - ainetus#6 shortest_paths.py: shared _make_incentivized_weight, multigraph-correct (min parallel weight + (u,v)/(u,v,key) promoted matching); dead branch removed. - ainetus#7 to_DiGraph: a missing capacity now defaults to 0.0 (neutral in the min-cut) instead of a spurious 1.0. Maintainability: - interactive_html.py (976 LOC) -> package interactive_html/ (8 focused modules) with the CSS/JS/HTML skeleton externalised under assets/ and reassembled byte-exactly at runtime; shipped via package_data + MANIFEST.in. Docs: CLAUDE.md and docs/CODE_REVIEW.md updated. All graph-package / ranking / renderer / create_df / interactive-html unit suites pass (367) without grid2op. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ
marota
pushed a commit
to marota/ExpertOp4Grid_marota
that referenced
this pull request
Jul 16, 2026
Feuille de route des pistes restantes (open findings ainetus#4/ainetus#6/ainetus#7, CI static-analysis repoint, mixins->composition, interactive_html/Grid2opSimulation decomposition, model-vs-colour inversion, AlphaDeesp run() API, naming aliases, grid2op CI validation + release/bump). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ Signed-off-by: Antoine Marot <amarot91@gmail.com>
marota
pushed a commit
to marota/ExpertOp4Grid_marota
that referenced
this pull request
Jul 16, 2026
…aph, create_df, shortest paths, interactive_html split Deep revisions: - Model/colour inversion: new graphs/edge_roles.py (edge_role_of / base_color_of / EDGE_ROLE_*). tag_constrained_path reads the semantic role instead of parsing the Graphviz colour string; highlight_significant_line_loading records an authoritative base_color when it wraps a colour into the compound "c:yellow:c"; new OverFlowGraph.edge_role(name). Exported via the package + shim. - AlphaDeesp.__init__ -> explicit run(): the ranking pipeline moved into run(); auto_run=True (default) preserves backwards-compatible construction; results are initialised empty so auto_run=False builds a well-formed, un-run object. - Structured_Overload_Distribution_Graph: colour-filtered views, red_loops and hubs are now functools.cached_property (constrained path stays eager). red_loops uses the constructor seed hubs; public find_loops() uses the detected hubs — this split makes the lazy properties order-independent while matching the old eager behaviour exactly. Open findings: - ainetus#4 create_df: vectorised the iterrows passes with numpy masks; ltc_report now uses positional .iloc. Behaviour pinned by a 400-case differential fuzz against a faithful re-implementation of the original loop. - ainetus#6 shortest_paths.py: shared _make_incentivized_weight, multigraph-correct (min parallel weight + (u,v)/(u,v,key) promoted matching); dead branch removed. - ainetus#7 to_DiGraph: a missing capacity now defaults to 0.0 (neutral in the min-cut) instead of a spurious 1.0. Maintainability: - interactive_html.py (976 LOC) -> package interactive_html/ (8 focused modules) with the CSS/JS/HTML skeleton externalised under assets/ and reassembled byte-exactly at runtime; shipped via package_data + MANIFEST.in. Docs: CLAUDE.md and docs/CODE_REVIEW.md updated. All graph-package / ranking / renderer / create_df / interactive-html unit suites pass (367) without grid2op. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013XzsGr6toJXzsLdoKqM5KJ Signed-off-by: Antoine Marot <amarot91@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.