Skip to content

cibuildwheel: remove useless pp* skip selector - #13657

Merged
webknjaz merged 4 commits into
aio-libs:masterfrom
Polandia94:remove-cibuildwheel-pp-skip
Sep 8, 2026
Merged

cibuildwheel: remove useless pp* skip selector#13657
webknjaz merged 4 commits into
aio-libs:masterfrom
Polandia94:remove-cibuildwheel-pp-skip

Conversation

@Polandia94

@Polandia94 Polandia94 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What do these changes do?

Removes the dead pp* cibuildwheel skip selector. PyPy build groups have not been enabled by default since cibuildwheel 3.0, so the selector matches nothing and cibuildwheel only warns:

Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled.

Mirrors aio-libs/multidict#1283, removing it from both pyproject.toml and .github/workflows/ci-cd.yml (the workflow-level CIBW_SKIP env var would otherwise keep injecting the selector regardless of the pyproject.toml setting).

Are there changes in behavior for the user?

No. Only the wheel build pipeline configuration changes, not the published wheels.

Is it a substantial burden for the maintainers to support this?

No, it removes dead configuration rather than adding any.

Related issue number

Related to aio-libs/multidict#1283 (does not close it).

Checklist

  • I think the code is well written
  • Unit tests for the changes exist (N/A, CI-only configuration change)
  • Documentation reflects the changes (N/A)
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt (N/A, no library code change)
  • Add a new news fragment into the CHANGES/ folder
Agent run details (optional, for reviewers)

Verified: grepped the full working tree for pp* after the change (no matches left), and confirmed pyproject.toml (tomllib) and .github/workflows/ci-cd.yml (PyYAML) still parse. Did not run the full test suite or make doc-spelling in the environment this was drafted in, since network access there is restricted; please confirm CI is green before marking ready.

Drafted with Claude (Sonnet 5) in a Cowork session. Reviewed by @Polandia94

@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Sep 7, 2026
@Polandia94
Polandia94 marked this pull request as ready for review September 7, 2026 17:39
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (529d66a) to head (0474463).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13657   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         135      135           
  Lines       50845    50845           
  Branches     2674     2674           
=======================================
  Hits        50351    50351           
  Misses        370      370           
  Partials      124      124           
Flag Coverage Δ
Autobahn 21.97% <ø> (ø)
CI-GHA 98.92% <ø> (ø)
OS-Linux 98.69% <ø> (ø)
OS-Windows 97.31% <ø> (ø)
OS-macOS 98.18% <ø> (ø)
Py-3.10 98.12% <ø> (ø)
Py-3.11 98.35% <ø> (ø)
Py-3.12 98.43% <ø> (ø)
Py-3.13 98.42% <ø> (ø)
Py-3.14 98.45% <ø> (ø)
Py-3.14t 97.82% <ø> (-0.01%) ⬇️
Py-pypy-3.11 97.38% <ø> (-0.03%) ⬇️
VM-macos 98.18% <ø> (ø)
VM-ubuntu 98.69% <ø> (ø)
VM-windows 97.31% <ø> (ø)
cython-coverage 83.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Polandia94
Polandia94 force-pushed the remove-cibuildwheel-pp-skip branch from b3ac0d5 to 87fdc4d Compare September 7, 2026 17:43
@greptile-apps

greptile-apps Bot commented Sep 7, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

Safe to merge; the wheel-build selector change preserves the tested effective build set.

No blocking failure remains.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the cibuildwheel PyPy-skip comparison script against cibuildwheel 3.4.1 to validate the two skip-variant executions.
  • Validated the output shows identical CPython-only IDs for x86_64 and aarch64, with PyPy identifiers: 0, and a clean exit (exit code 0).

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (5): Last reviewed commit: "Merge branch 'master' into remove-cibuil..." | Re-trigger Greptile

@Polandia94
Polandia94 marked this pull request as draft September 7, 2026 17:57
@codspeed-hq

codspeed-hq Bot commented Sep 7, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 97 untouched benchmarks
⏩ 83 skipped benchmarks1


Comparing Polandia94:remove-cibuildwheel-pp-skip (0474463) with master (529d66a)2

Open in CodSpeed

Footnotes

  1. 83 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (926062b) during the generation of this report, so 529d66a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Polandia94
Polandia94 marked this pull request as ready for review September 7, 2026 18:01
@Polandia94

Copy link
Copy Markdown
Contributor Author

Confidence Score: 4/5

Not ready to merge until the spelling allowlist is restored to the repository-required sort order.

The only independent finding is a non-security P2 repository-rule violation, which maps to a score of 4.

Files Needing Attention: docs/spelling_wordlist.txt

Comments Outside Diff (1)

  1. docs/spelling_wordlist.txt, line 276-280 (link)
    P2 Spelling entries are unsorted
    pyproject appears before py, but the case-insensitive wordlist order requires it after pyflakes. Reorder these entries so the repository's sorting check does not reject or rewrite the file.
    Context Used: AGENTS.md (source)

Reviews (1): Last reviewed commit: "cibuildwheel: remove useless pp* skip se..." | Re-trigger Greptile

fixed

@Polandia94 Polandia94 added backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Sep 7, 2026
Comment thread CHANGES/13657.contrib.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need a change note for something that doesn't change anything, and certainly shouldn't be expanding the spelling list with filenames.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed on 9674955. I will remove form the other PRs.

@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Sep 7, 2026
@Polandia94
Polandia94 force-pushed the remove-cibuildwheel-pp-skip branch 2 times, most recently from a743a51 to 591967c Compare September 8, 2026 12:14
@Polandia94 Polandia94 removed the bot:chronographer:provided There is a change note present in this PR label Sep 8, 2026
Polandia94 and others added 3 commits September 8, 2026 12:52
Co-authored-by: Julien Stephan <31988046+justeph@users.noreply.github.com>
@Polandia94
Polandia94 force-pushed the remove-cibuildwheel-pp-skip branch from 1a3a889 to 2904eec Compare September 8, 2026 12:55
@webknjaz
webknjaz merged commit 847e80c into aio-libs:master Sep 8, 2026
52 checks passed
@patchback

patchback Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Backport to 3.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.15/847e80cf3e10062b8cdda615d8a771bf6a3c3368/pr-13657

Backported as #13668

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/847e80cf3e10062b8cdda615d8a771bf6a3c3368/pr-13657

Backported as #13669

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

webknjaz pushed a commit that referenced this pull request Sep 9, 2026
…skip selector (#13668)

**This is a backport of PR #13657 as merged into master
(847e80c).**

<!-- Thank you for your contribution! -->

## What do these changes do?

Removes the dead `pp*` cibuildwheel skip selector. PyPy build groups
have not been enabled by default since cibuildwheel 3.0, so the selector
matches nothing and cibuildwheel only warns:

Invalid skip selector: 'pp*'. This selector matches a group that wasn't
enabled.

Mirrors aio-libs/multidict#1283, removing it from both `pyproject.toml`
and `.github/workflows/ci-cd.yml` (the workflow-level `CIBW_SKIP` env
var would otherwise keep injecting the selector regardless of the
pyproject.toml setting).

## Are there changes in behavior for the user?

No. Only the wheel build pipeline configuration changes, not the
published wheels.

## Is it a substantial burden for the maintainers to support this?

No, it removes dead configuration rather than adding any.

## Related issue number

Related to aio-libs/multidict#1283 (does not close it).

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, CI-only configuration
change)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A, no library code change)
- [x] Add a new news fragment into the `CHANGES/` folder

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Verified: grepped the full working tree for `pp*` after the change (no
matches left), and confirmed `pyproject.toml` (tomllib) and
`.github/workflows/ci-cd.yml` (PyYAML) still parse. Did not run the full
test suite or `make doc-spelling` in the environment this was drafted
in, since network access there is restricted; please confirm CI is green
before marking ready.
</details>

Drafted with Claude (Sonnet 5) in a Cowork session. Reviewed by
@Polandia94

Co-authored-by: Pablo Nicolás Estevez <pablo22estevez@gmail.com>
Co-authored-by: Julien Stephan <31988046+justeph@users.noreply.github.com>
webknjaz pushed a commit that referenced this pull request Sep 9, 2026
…skip selector (#13669)

**This is a backport of PR #13657 as merged into master
(847e80c).**

<!-- Thank you for your contribution! -->

## What do these changes do?

Removes the dead `pp*` cibuildwheel skip selector. PyPy build groups
have not been enabled by default since cibuildwheel 3.0, so the selector
matches nothing and cibuildwheel only warns:

Invalid skip selector: 'pp*'. This selector matches a group that wasn't
enabled.

Mirrors aio-libs/multidict#1283, removing it from both `pyproject.toml`
and `.github/workflows/ci-cd.yml` (the workflow-level `CIBW_SKIP` env
var would otherwise keep injecting the selector regardless of the
pyproject.toml setting).

## Are there changes in behavior for the user?

No. Only the wheel build pipeline configuration changes, not the
published wheels.

## Is it a substantial burden for the maintainers to support this?

No, it removes dead configuration rather than adding any.

## Related issue number

Related to aio-libs/multidict#1283 (does not close it).

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, CI-only configuration
change)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A, no library code change)
- [x] Add a new news fragment into the `CHANGES/` folder

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Verified: grepped the full working tree for `pp*` after the change (no
matches left), and confirmed `pyproject.toml` (tomllib) and
`.github/workflows/ci-cd.yml` (PyYAML) still parse. Did not run the full
test suite or `make doc-spelling` in the environment this was drafted
in, since network access there is restricted; please confirm CI is green
before marking ready.
</details>

Drafted with Claude (Sonnet 5) in a Cowork session. Reviewed by
@Polandia94

Co-authored-by: Pablo Nicolás Estevez <pablo22estevez@gmail.com>
Co-authored-by: Julien Stephan <31988046+justeph@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants