cibuildwheel: remove useless pp* skip selector - #13657
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13657 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 135 135
Lines 50845 50845
Branches 2674 2674
=======================================
Hits 50351 50351
Misses 370 370
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
b3ac0d5 to
87fdc4d
Compare
Confidence Score: 5/5Safe to merge; the wheel-build selector change preserves the tested effective build set. No blocking failure remains.
What T-Rex did
Reviews (5): Last reviewed commit: "Merge branch 'master' into remove-cibuil..." | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
fixed |
There was a problem hiding this comment.
Not sure we need a change note for something that doesn't change anything, and certainly shouldn't be expanding the spelling list with filenames.
There was a problem hiding this comment.
removed on 9674955. I will remove form the other PRs.
a743a51 to
591967c
Compare
Co-authored-by: Julien Stephan <31988046+justeph@users.noreply.github.com>
1a3a889 to
2904eec
Compare
Backport to 3.15: 💚 backport PR created✅ Backport PR branch: Backported as #13668 🤖 @patchback |
Backport to 3.14: 💚 backport PR created✅ Backport PR branch: Backported as #13669 🤖 @patchback |
…skip selector (#13668) **This is a backport of PR #13657 as merged into master (847e80c).** <!-- Thank you for your contribution! --> ## What do these changes do? Removes the dead `pp*` cibuildwheel skip selector. PyPy build groups have not been enabled by default since cibuildwheel 3.0, so the selector matches nothing and cibuildwheel only warns: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Mirrors aio-libs/multidict#1283, removing it from both `pyproject.toml` and `.github/workflows/ci-cd.yml` (the workflow-level `CIBW_SKIP` env var would otherwise keep injecting the selector regardless of the pyproject.toml setting). ## Are there changes in behavior for the user? No. Only the wheel build pipeline configuration changes, not the published wheels. ## Is it a substantial burden for the maintainers to support this? No, it removes dead configuration rather than adding any. ## Related issue number Related to aio-libs/multidict#1283 (does not close it). ## Checklist - [x] I think the code is well written - [ ] Unit tests for the changes exist (N/A, CI-only configuration change) - [ ] Documentation reflects the changes (N/A) - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` (N/A, no library code change) - [x] Add a new news fragment into the `CHANGES/` folder <details> <summary>Agent run details (optional, for reviewers)</summary> Verified: grepped the full working tree for `pp*` after the change (no matches left), and confirmed `pyproject.toml` (tomllib) and `.github/workflows/ci-cd.yml` (PyYAML) still parse. Did not run the full test suite or `make doc-spelling` in the environment this was drafted in, since network access there is restricted; please confirm CI is green before marking ready. </details> Drafted with Claude (Sonnet 5) in a Cowork session. Reviewed by @Polandia94 Co-authored-by: Pablo Nicolás Estevez <pablo22estevez@gmail.com> Co-authored-by: Julien Stephan <31988046+justeph@users.noreply.github.com>
…skip selector (#13669) **This is a backport of PR #13657 as merged into master (847e80c).** <!-- Thank you for your contribution! --> ## What do these changes do? Removes the dead `pp*` cibuildwheel skip selector. PyPy build groups have not been enabled by default since cibuildwheel 3.0, so the selector matches nothing and cibuildwheel only warns: Invalid skip selector: 'pp*'. This selector matches a group that wasn't enabled. Mirrors aio-libs/multidict#1283, removing it from both `pyproject.toml` and `.github/workflows/ci-cd.yml` (the workflow-level `CIBW_SKIP` env var would otherwise keep injecting the selector regardless of the pyproject.toml setting). ## Are there changes in behavior for the user? No. Only the wheel build pipeline configuration changes, not the published wheels. ## Is it a substantial burden for the maintainers to support this? No, it removes dead configuration rather than adding any. ## Related issue number Related to aio-libs/multidict#1283 (does not close it). ## Checklist - [x] I think the code is well written - [ ] Unit tests for the changes exist (N/A, CI-only configuration change) - [ ] Documentation reflects the changes (N/A) - [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` (N/A, no library code change) - [x] Add a new news fragment into the `CHANGES/` folder <details> <summary>Agent run details (optional, for reviewers)</summary> Verified: grepped the full working tree for `pp*` after the change (no matches left), and confirmed `pyproject.toml` (tomllib) and `.github/workflows/ci-cd.yml` (PyYAML) still parse. Did not run the full test suite or `make doc-spelling` in the environment this was drafted in, since network access there is restricted; please confirm CI is green before marking ready. </details> Drafted with Claude (Sonnet 5) in a Cowork session. Reviewed by @Polandia94 Co-authored-by: Pablo Nicolás Estevez <pablo22estevez@gmail.com> Co-authored-by: Julien Stephan <31988046+justeph@users.noreply.github.com>
What do these changes do?
Removes the dead
pp*cibuildwheel skip selector. PyPy build groups have not been enabled by default since cibuildwheel 3.0, so the selector matches nothing and cibuildwheel only warns:Mirrors aio-libs/multidict#1283, removing it from both
pyproject.tomland.github/workflows/ci-cd.yml(the workflow-levelCIBW_SKIPenv var would otherwise keep injecting the selector regardless of the pyproject.toml setting).Are there changes in behavior for the user?
No. Only the wheel build pipeline configuration changes, not the published wheels.
Is it a substantial burden for the maintainers to support this?
No, it removes dead configuration rather than adding any.
Related issue number
Related to aio-libs/multidict#1283 (does not close it).
Checklist
CONTRIBUTORS.txt(N/A, no library code change)CHANGES/folderAgent run details (optional, for reviewers)
Verified: grepped the full working tree for
pp*after the change (no matches left), and confirmedpyproject.toml(tomllib) and.github/workflows/ci-cd.yml(PyYAML) still parse. Did not run the full test suite ormake doc-spellingin the environment this was drafted in, since network access there is restricted; please confirm CI is green before marking ready.Drafted with Claude (Sonnet 5) in a Cowork session. Reviewed by @Polandia94