Aiodns support - #747
Conversation
Conflicts: requirements-dev.txt tests/test_helpers.py tests/test_signals.py
There was a problem hiding this comment.
Strictly speaking thread pool is just internal details of asyncio implementation, and may be change in future. I'd call it 'DefaultResolver' and document it as default asyncio based resolver
There was a problem hiding this comment.
Please rewrite tests to use py.test style (like test_client_connection.py for example).
|
Any way I can help this feature move forward? |
|
@lphuberdeau I was planning to continue on this PR in a week or 2-3 but I am absolutely swamped right now. You're most welcome to contribute if you have an earlier opportunity. Let me know. |
|
@gwillem I've branched off your work. I'll notify you when the pull request is ready to be updated. |
|
https://github.com/lphuberdeau/aiohttp/tree/aiodns-support
I'm a bit unclear about what needs to be tested in the TCPConnector without mocking absolutely everything. About the missing .close(), it could be added, but given the object is instantiated outside of the connector, I'm not certain it is the connector's responsibility. |
b497c05 to
ff36775
Compare
|
Apparently pycares does not build on Win arch. Is this a showstopper, given that Aiodns is optional? @lphuberdeau great work btw! |
|
The tests will run fine without it as the skips are in place. Everything in pycares seem to indicate it should build on windows. To resolve the CI issue, I see two options:
|
|
FYI I have since migrated back to Tornado's AsyncHTTPClient for the following reasons:
IMHO aiohttp is cleaner, especially with native support for asyncio. And I would love to use aiohttp in the future. But right now I have deadlines :) so I need to be pragmatic. |
|
@gwillem If you no longer want to track this issue, I can probably submit it back under a different PR and handle the back and forth. |
|
@lphuberdeau ok, please do! And again, thanks for joining in. |
|
Feel free to close this one. |
4 participants
Fixes #728. Todo: