feat(workspace): show completed turn runtime icons - #613
Conversation
Resolve each message's framework, provider, and model from its existing runtime segment so historical footer metadata stays tied to the turn that produced it.
Codex ReviewVerdict: mergeable No actionable findings. Summary: No concrete merge-blocking defects found. Static inspection only; branch and pull request title prechecks are valid. |
Codex ReviewVerdict: needs changes [P2] Do not treat synthesized legacy segments as authoritative runtime identitysrc/renderer/src/pages/workspace/WorkspaceMessageScroller.tsx:564 Impact: Legacy sessions without a conversation graph are synthesized with a default Recommendation: Mark compatibility-generated segments as metadata-unavailable, or gate [P2] Subscribe to settings while the usage popover is opensrc/renderer/src/pages/workspace/WorkspaceMessageItem.tsx:147 Impact: The popover reads settings with Recommendation: Resolve metadata in a child mounted with the popover and subscribe to the relevant settings selectors, preserving the current performance isolation from the full transcript. Summary: The PR mislabels legacy messages and can display stale runtime metadata after settings updates. |
|
Addressed both findings in
Validation: the focused Workspace tests pass (54/54), lint and typecheck pass. The full suite passed 9,756 tests with one unrelated timeout; its isolated retry passed 22/22. |
Codex ReviewVerdict: mergeable No actionable findings. Summary: Static inspection found no concrete merge-blocking defects in the pull request changes. |
|
Added compact Settings-reused icons before the Validation: focused test 20/20, full suite 9,757/9,757, typecheck passed, and lint completed with the same 19 pre-existing warnings and no errors. |
Codex ReviewVerdict: mergeable No actionable findings. Summary: Static inspection found no concrete merge-blocking defects introduced by this pull request. |
|
Added the selected Lucide Validation: focused test 20/20, full suite 9,757/9,757, typecheck passed, and lint completed with the same 19 pre-existing warnings and no errors. |
Codex ReviewVerdict: mergeable No actionable findings. Summary: No concrete merge-blocking defects found in the reviewed changes. |
Problem
Completed-message footers do not identify the ACP framework or model that produced a turn, and icons alone are not explicit enough when reviewing historical messages.
Proposed change
Scope and non-goals
Acceptance criteria and validation
All checks ran after the final material edit.
Uncovered risk: no new pixel-level visual-regression snapshot was added; the interaction tests verify the popover content, icon source, accessible hover labels, and omission behavior.
Review focus
Please confirm that resolving runtime identity from message.runtimeSegmentId preserves historical attribution when Settings change, and that the muted Agent and Model lines provide enough clarity without making the completed-message footer noisier.