Skip to content

fix(workspace): use semantic runtime label icons - #618

Merged
ewen-poch merged 1 commit into
mainfrom
fix/runtime-label-icons
Aug 2, 2026
Merged

fix(workspace): use semantic runtime label icons#618
ewen-poch merged 1 commit into
mainfrom
fix/runtime-label-icons

Conversation

@ewen-poch

Copy link
Copy Markdown
Member

Problem

The runtime detail rows added in #613 used framework and provider brand icons. Those icons identify the concrete runtime, but the rows need semantic labels matching Settings: Bot for Agent and Brain for Model.

Proposed change

  • Reuse the Lucide Bot and Brain icons already used by Settings.
  • Keep the branded framework and provider icons in the Usage header.
  • Render the Brain icon whenever a Model row is available, including when its provider no longer resolves.
  • Assert the exact semantic SVG icons in the existing renderer test.

Scope and non-goals

This changes presentation only. It does not change architecture, persisted data, runtime resolution, historical visibility, or interaction behavior.

Acceptance criteria and validation

All checks below ran after the last material edit:

  • Semantic Agent and Model detail icons -> /Users/eweno/projects/aipoch/open-science/node_modules/.bin/vitest run src/renderer/src/pages/workspace/WorkspaceMessageItem.mentions.test.tsx -> 20 passed.
  • Type safety -> npm run typecheck -> passed.
  • Lint -> npm run lint -> 0 errors; 19 existing warnings outside the changed files.
  • Regression suite -> npm test -> 669 files passed, 15 skipped; 9,764 tests passed, 184 skipped.

Uncovered risk: no screenshot regression was added; the rendered icon components and classes are covered directly by the component test.

Review focus

Confirm the bottom detail rows use fixed Bot and Brain semantics while the Usage header retains framework and provider branding.

@ewen-poch

Copy link
Copy Markdown
Member Author

The detail-row icons now follow the semantic Settings navigation: Bot for Agent and Brain for Model. Framework and provider branding remains limited to the Usage header, so the two locations communicate different information without changing runtime metadata or historical visibility.

@github-actions github-actions Bot added the bug Something isn't working label Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codex Review

Verdict: mergeable

No actionable findings.

Summary: Static inspection found no concrete merge-blocking defects in the pull request changes.

@github-actions github-actions Bot added the ready-to-merge All completed AI reviewers found this pull request mergeable. label Aug 2, 2026
@ewen-poch
ewen-poch merged commit a842397 into main Aug 2, 2026
23 checks passed
@ewen-poch
ewen-poch deleted the fix/runtime-label-icons branch August 2, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready-to-merge All completed AI reviewers found this pull request mergeable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant