fix(workspace): use semantic runtime label icons - #618
Merged
Conversation
Member
Author
|
The detail-row icons now follow the semantic Settings navigation: Bot for Agent and Brain for Model. Framework and provider branding remains limited to the Usage header, so the two locations communicate different information without changing runtime metadata or historical visibility. |
Codex ReviewVerdict: mergeable No actionable findings. Summary: Static inspection found no concrete merge-blocking defects in the pull request changes. |
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The runtime detail rows added in #613 used framework and provider brand icons. Those icons identify the concrete runtime, but the rows need semantic labels matching Settings: Bot for Agent and Brain for Model.
Proposed change
Scope and non-goals
This changes presentation only. It does not change architecture, persisted data, runtime resolution, historical visibility, or interaction behavior.
Acceptance criteria and validation
All checks below ran after the last material edit:
/Users/eweno/projects/aipoch/open-science/node_modules/.bin/vitest run src/renderer/src/pages/workspace/WorkspaceMessageItem.mentions.test.tsx-> 20 passed.npm run typecheck-> passed.npm run lint-> 0 errors; 19 existing warnings outside the changed files.npm test-> 669 files passed, 15 skipped; 9,764 tests passed, 184 skipped.Uncovered risk: no screenshot regression was added; the rendered icon components and classes are covered directly by the component test.
Review focus
Confirm the bottom detail rows use fixed Bot and Brain semantics while the Usage header retains framework and provider branding.