Skip to content

Configure Njord release publishing - #28

Merged
dain merged 1 commit into
masterfrom
user/dain/fix-release-workflow
Jul 21, 2026
Merged

Configure Njord release publishing#28
dain merged 1 commit into
masterfrom
user/dain/fix-release-workflow

Conversation

@dain

@dain dain commented Jul 21, 2026

Copy link
Copy Markdown
Member

Why

  • The release workflow follows the POM's direct Maven Central URL, which rejects uploads before Njord can validate and publish them.
  • Bytecode is missing the shared Maven and Njord configuration used by successful Airlift release workflows.
  • Without an early check, routing or credential problems are discovered only after release preparation has begun.

Approach

  • Load the standard Airlift Maven settings for Sonatype Central publishing through Njord.
  • Verify Central authentication and the effective Njord release route before preparing a release.

The release currently follows the POM's direct Maven Central URL, which
rejects uploads before Njord can validate and publish them. Load the
shared Airlift settings and fail early unless credentials and the Njord
release route are active.
@dain
dain marked this pull request as ready for review July 21, 2026 19:00
@dain
dain requested a review from electrum July 21, 2026 19:00
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Maven configuration now loads a project settings file defining Sonatype credentials from environment variables, the Njord publisher, and the release URL. The release workflow adds a verification step that runs njord:status, captures its output, and checks authentication and the effective release SCA template before release preparation.

Possibly related PRs

  • airlift/bytecode#27: Adds related Maven Central publication and release configuration checks.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db0b8a48-449d-4b5e-9dff-45a29fba19f7

📥 Commits

Reviewing files that changed from the base of the PR and between 9ce50d8 and 9f43f91.

📒 Files selected for processing (3)
  • .github/workflows/release.yml
  • .mvn/maven.config
  • .mvn/settings.xml

Comment thread .github/workflows/release.yml
Comment thread .mvn/maven.config
@dain
dain merged commit de7d022 into master Jul 21, 2026
2 checks passed
@dain
dain deleted the user/dain/fix-release-workflow branch July 21, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants