feat(styling): add flag-gated top navigation replacing sidebar - #3448
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe layout now selects a feature-flagged responsive top navigation with account controls, theme persistence, active routes, settings links, mobile navigation, and shared header-height synchronization. ChangesTop navigation rollout
Estimated code review effort: 3 (Moderate) | ~30 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3448 +/- ##
==========================================
- Coverage 72.84% 71.97% -0.87%
==========================================
Files 1168 1084 -84
Lines 29585 27420 -2165
Branches 7331 6939 -392
==========================================
- Hits 21551 19736 -1815
+ Misses 7070 6754 -316
+ Partials 964 930 -34
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/deploy-web/src/components/layout/TopNav/ThemeToggle.tsx`:
- Around line 25-28: Update onThemeClick to persist the theme cookie beyond the
current session by adding an appropriate Max-Age or Expires attribute to the
document.cookie assignment, while preserving the existing theme value and path.
In `@apps/deploy-web/src/components/layout/TopNav/TopNav.tsx`:
- Around line 55-67: Update isRouteActive in TopNav to match route prefixes only
when pathname equals the prefix or continues with a slash boundary, preventing
paths such as /providers-old from being marked active. Preserve the existing
multi-prefix behavior and pathname guard.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ba50dd97-0d0d-468d-a133-f1c81db57a77
📒 Files selected for processing (10)
apps/deploy-web/src/components/layout/Layout.tsxapps/deploy-web/src/components/layout/Nav.tsxapps/deploy-web/src/components/layout/TopNav/ThemeToggle.spec.tsxapps/deploy-web/src/components/layout/TopNav/ThemeToggle.tsxapps/deploy-web/src/components/layout/TopNav/TopNav.spec.tsxapps/deploy-web/src/components/layout/TopNav/TopNav.tsxapps/deploy-web/src/components/layout/TopNav/TopNavAccountMenu.spec.tsxapps/deploy-web/src/components/layout/TopNav/TopNavAccountMenu.tsxapps/deploy-web/src/components/layout/usePublishHeaderHeight.tsapps/deploy-web/src/types/feature-flags.ts
… refine spacing Add sidebar-matching icons to the mobile nav links, give the sheet proper padding so the logo no longer touches the edge, fold the account menu into the single mobile hamburger via an inline variant, and widen the desktop header padding.
2 participants
Why
Closes CON-298
Console Redesign v2 moves primary navigation from the left sidebar to a single top nav bar: it frees horizontal space for content-heavy pages (configure deployment, deployment details), reduces cognitive load for the most-visited pages, and aligns with AkashML's nav structure. Design approved in Figma (see issue).
What
Everything ships behind a new
ui_top_navUnleash flag (off by default) — flag-off keeps the current sidebar chrome byte-for-byte; old components are removed in a post-rollout cleanup ticket.TopNav: logo · Deployments / Providers / Templates (active state viaaria-current) · Settings dropdown (Billing + Usage behindbilling_usage, API Keys, Alerts behindalerts) · hackathon coupon entry · avatar menu. No wallet balance pill per product decision. RendersTopBannerand publishes--app-header-heightlike the oldNav(hook extracted tousePublishHeaderHeightand shared). Mobile: hamburger →Sheetwith the same links.minimalmode preserves the stripped onboarding chrome.TopNavAccountMenu: Profile →/user/settings, inline Theme (Light|Dark segmented control, keeps the SSRthemecookie), Docs (new tab), Privacy Policy, Terms of Service, Contact us, Log out; Sign up/Sign in when signed out.Layoutbranches on the flag: TopNav-only chrome with full-width content when on, unchanged sidebar layout when off.Runtime-verified locally (Playwright against
npm run dev):Rollout notes
ui_top_navmust be created in Unleash (off); local dev sees it ON viaNEXT_PUBLIC_UNLEASH_ENABLE_ALL.tests/ui/pages/Sidebar.ts) navigate via the sidebar — update them before enabling the flag in test environments.Summary by CodeRabbit