fix(styling): reserve page loading-bar height on all pages - #3468
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesLayout dependency injection and loading behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3468 +/- ##
==========================================
- Coverage 73.05% 72.18% -0.87%
==========================================
Files 1175 1085 -90
Lines 29797 27543 -2254
Branches 7404 6953 -451
==========================================
- Hits 21769 19883 -1886
+ Misses 7062 6727 -335
+ Partials 966 933 -33
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
Navigating between pages shifts all page content vertically by 4px. The layout only rendered the top loading bar when a page passed the
isLoadingprop: the ~9 pages that pass it (deployments, providers, home, etc.) always reserve a 4px strip, while the ~18 pages that omit it (alerts, billing, sdl-builder, faq, etc.) reserve 0px, so the content top jumps depending on which page you land on.What
Always render
LinearLoadingSkeletonin the deploy-webLayout, defaultingisLoadingtofalse. The skeleton is already shift-free on its own (4pxLinearProgresswhen loading, 4px placeholder when idle), so every page now reserves the same 4px strip whether or not it has a loading state. No page call-site changes needed.Verified against a local dev server on
/faq(a page that does not passisLoading):isLoading)Summary by CodeRabbit