Simplify code - #23
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## qt-speedup #23 +/- ##
=============================================
Coverage ? 65.71%
=============================================
Files ? 348
Lines ? 54573
Branches ? 3831
=============================================
Hits ? 35865
Misses ? 18312
Partials ? 396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akx
requested changes
Sep 4, 2026
| @@ -56,11 +56,6 @@ def test_closed_file() -> None: | |||
|
|
|||
|
|
|||
| def test_deprecated_align8to32_matches_new_impl() -> None: | |||
Owner
There was a problem hiding this comment.
If you're going to remove the "matches new impl" bit of the test, maybe the name of the test should be changed too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions for python-pillow#9940
See what you think of these ideas.
_aligned_strideinto the parent function, but I understand if you disagree