Skip to content

refactor: extract window session protocol - #272

Merged
alecdotdev merged 1 commit into
alecdotdev:masterfrom
PathGao:agent/extract-window-session
Jul 30, 2026
Merged

refactor: extract window session protocol#272
alecdotdev merged 1 commit into
alecdotdev:masterfrom
PathGao:agent/extract-window-session

Conversation

@PathGao

@PathGao PathGao commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move persisted window-state cleanup and saving into the windowSession module
  • move detached-tab staging, acknowledgement, cancellation, and error handling into the same module
  • keep MarkdownViewer responsible only for tab-specific policy and callbacks
  • relocate structural regression checks with their implementation

Depends on #271 and should be merged after it. This is the second focused step in the #236 componentization sequence; listener ownership will follow separately.

Validation

  • npm run check
  • npm test (117 passing)
  • cargo test (18 passing)

@PathGao

PathGao commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev This is the next dependent componentization PR after #271. It isolates the window-state persistence and detached-tab transfer protocol; listener ownership remains a separate follow-up to keep review scope small.

@alecdotdev

Copy link
Copy Markdown
Owner

@PathGao minor conflict emerged after merging #271 other than that, LGTM

@PathGao
PathGao force-pushed the agent/extract-window-session branch from 27b969b to a420161 Compare July 30, 2026 04:00
@PathGao

PathGao commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev #271 is now merged, so I rebased this dependent branch onto current master and reran its parent relationship. #273#275 were rebased linearly on top of the rewritten chain.

@PathGao

PathGao commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

All checks are now green for #272 through #278. The remaining #279/#280 build matrix is still running. Once #272 merges, I will rebase and re-verify the next branch in the stack immediately.

@alecdotdev
alecdotdev merged commit 0ce9d91 into alecdotdev:master Jul 30, 2026
5 checks passed
@PathGao
PathGao deleted the agent/extract-window-session branch July 30, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants