Skip to content

refactor: move document saving into session - #275

Merged
alecdotdev merged 2 commits into
alecdotdev:masterfrom
PathGao:agent/extract-document-persistence
Jul 30, 2026
Merged

refactor: move document saving into session#275
alecdotdev merged 2 commits into
alecdotdev:masterfrom
PathGao:agent/extract-document-persistence

Conversation

@PathGao

@PathGao PathGao commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move normal and first-save document persistence into documentSession
  • preserve snapshot-based dirty-state handling during asynchronous writes
  • retain watcher suppression and recent-file presentation through explicit viewer callbacks

Depends on #274. Merge after #274. Save-as, task mutation, watcher, and close flows remain the next document-session steps.

Validation

  • npm run check
  • npm test (117 passing)
  • cargo test (18 passing)

@PathGao

PathGao commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev This follows #274. It moves normal and first-save persistence into documentSession while retaining the existing snapshot/TOCTOU and watcher-suppression invariants. The next dependent step covers save-as, task mutation, watcher, and close flows.

@PathGao
PathGao force-pushed the agent/extract-document-persistence branch from 8074312 to 93c8e79 Compare July 30, 2026 04:00
@PathGao

PathGao commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev Rebased after #271 merged; its direct parent is the updated #274 branch.

@PathGao
PathGao force-pushed the agent/extract-document-persistence branch 2 times, most recently from 84598e6 to 1032272 Compare July 30, 2026 05:04
@PathGao
PathGao force-pushed the agent/extract-document-persistence branch from 1032272 to 6bf97d7 Compare July 30, 2026 05:06
@alecdotdev
alecdotdev merged commit df2cb2f into alecdotdev:master Jul 30, 2026
5 checks passed
@PathGao
PathGao deleted the agent/extract-document-persistence branch July 30, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants