Skip to content

test: Add unit tests for metrics utilities - #20

Merged
alfieprojectsdev merged 1 commit into
mainfrom
test/add-metrics-tests-5465521941459795677
Feb 24, 2026
Merged

test: Add unit tests for metrics utilities#20
alfieprojectsdev merged 1 commit into
mainfrom
test/add-metrics-tests-5465521941459795677

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

Added unit tests for services/vadase-rt-monitor/src/utils/metrics.py covering compute_horizontal_magnitude, convert_m_to_mm, convert_mm_to_m, and compute_3d_magnitude. Tests cover standard inputs, zero values, negative values, and floating point precision.


PR created automatically by Jules for task 5465521941459795677 started by @alfieprojectsdev

Added unit tests for `services/vadase-rt-monitor/src/utils/metrics.py` covering:
- `compute_horizontal_magnitude`
- `convert_m_to_mm`
- `convert_mm_to_m`
- `compute_3d_magnitude`

Tests cover standard inputs, zero values, negative values, and floating point precision.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@alfieprojectsdev
alfieprojectsdev merged commit 4e727e7 into main Feb 24, 2026
alfieprojectsdev added a commit that referenced this pull request Feb 24, 2026
… use math.hypot (superseded)

Acknowledging PR closure due to supersession by #22 and #20.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
alfieprojectsdev added a commit that referenced this pull request Feb 24, 2026
Acknowledge that this PR is superseded by #20. No further changes needed.

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant