Skip to content

🧪 Add tests for metrics utility functions - #5

Closed
alfieprojectsdev wants to merge 1 commit into
mainfrom
testing-improvement-metrics-vadase-rt-monitor-2097731109998008477
Closed

🧪 Add tests for metrics utility functions#5
alfieprojectsdev wants to merge 1 commit into
mainfrom
testing-improvement-metrics-vadase-rt-monitor-2097731109998008477

Conversation

@alfieprojectsdev

Copy link
Copy Markdown
Owner

This PR adds comprehensive unit tests for the utility functions in services/vadase-rt-monitor/src/utils/metrics.py.

🎯 What: Addressed the lack of tests for compute_horizontal_magnitude and other related metrics functions.
📊 Coverage:

  • compute_horizontal_magnitude: Basic cases, zeros, negatives, single component, and float precision.
  • compute_3d_magnitude: 1-1-1 case, 3-4-12 case, and zeros.
  • convert_m_to_mm & convert_mm_to_m: Conversion accuracy and edge cases.
    Result: Improved reliability and test coverage for core monitoring calculations.

PR created automatically by Jules for task 2097731109998008477 started by @alfieprojectsdev

- Added tests for compute_horizontal_magnitude
- Added tests for compute_3d_magnitude
- Added tests for unit conversion functions (m to mm and mm to m)
- Verified tests pass with pytest
- Verified tests catch bugs by introducing deliberate failures

Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@alfieprojectsdev

Copy link
Copy Markdown
Owner Author

Closing: superseded by #20 (already merged) which covers all 4 metrics functions.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing: superseded by #20 (already merged) which covers all 4 metrics functions.

Understood. Acknowledging that this work is now obsolete as it has been superseded by #20, which already covers the metrics functions. Stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant