🧪 Add tests for metrics utility functions - #5
Conversation
- Added tests for compute_horizontal_magnitude - Added tests for compute_3d_magnitude - Added tests for unit conversion functions (m to mm and mm to m) - Verified tests pass with pytest - Verified tests catch bugs by introducing deliberate failures Co-authored-by: alfieprojectsdev <11991855+alfieprojectsdev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing: superseded by #20 (already merged) which covers all 4 metrics functions. |
This PR adds comprehensive unit tests for the utility functions in
services/vadase-rt-monitor/src/utils/metrics.py.🎯 What: Addressed the lack of tests for
compute_horizontal_magnitudeand other related metrics functions.📊 Coverage:
compute_horizontal_magnitude: Basic cases, zeros, negatives, single component, and float precision.compute_3d_magnitude: 1-1-1 case, 3-4-12 case, and zeros.convert_m_to_mm&convert_mm_to_m: Conversion accuracy and edge cases.✨ Result: Improved reliability and test coverage for core monitoring calculations.
PR created automatically by Jules for task 2097731109998008477 started by @alfieprojectsdev