Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Conversation

@francoischalifour
Copy link
Contributor

This adds a template for Autocomplete v1.

Changes

  • The Autocomplete.js template was renamed "Autocomplete.js 0" to avoid confusion (and it still doesn't appear in the CLI)
  • This new template is named "Autocomplete"

Preview

Sandbox preview

You can see a preview of what CISA generates in this sandbox →.

Comment on lines +132 to +134
- build_app:
template: 'Autocomplete'
app: 'autocomplete'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint version used in the template is not compatible with Node 10 so I only added the CI tests to Node 12.

@@ -1 +1 @@
12.14.1
14.15.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Node bump is required for Parcel 2.

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@francoischalifour francoischalifour merged commit 5c72d05 into master Sep 27, 2021
@francoischalifour francoischalifour deleted the feat/autocomplete-v1-template branch September 27, 2021 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants