This repository was archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
feat(autocomplete): add Autocomplete v1 template #528
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5388cb6
feat(autocomplete): add Autocomplete v1 template
francoischalifour aa2a66f
fix: use "items" instead of "products"
francoischalifour 39ec30c
fix: use `name` in document title
francoischalifour c65154c
fix: remove duplicate keyword
francoischalifour 1e75df5
test: update snapshots
francoischalifour 2149866
fix: undo change un release script
francoischalifour 5ed7d56
chore: run CI
francoischalifour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,7 +97,7 @@ jobs: | |
| - run: *run_yarn_install | ||
| - save_cache: *save_yarn_cache | ||
| - build_app: | ||
| template: 'Autocomplete.js' | ||
| template: 'Autocomplete.js 0' | ||
| app: 'autocomplete.js' | ||
| - build_app: | ||
| template: 'InstantSearch.js' | ||
|
|
@@ -127,8 +127,11 @@ jobs: | |
| template: 'Angular InstantSearch' | ||
| app: 'angular-instantsearch' | ||
| - build_app: | ||
| template: 'Autocomplete.js' | ||
| template: 'Autocomplete.js 0' | ||
| app: 'autocomplete.js' | ||
| - build_app: | ||
| template: 'Autocomplete' | ||
| app: 'autocomplete' | ||
|
Comment on lines
+132
to
+134
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The ESLint version used in the template is not compatible with Node 10 so I only added the CI tests to Node 12. |
||
| - build_app: | ||
| template: 'InstantSearch.js' | ||
| app: 'instantsearch.js' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 12.14.1 | ||
| 14.15.0 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A Node bump is required for Parcel 2. |
||
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.