This repository was archived by the owner on Dec 16, 2022. It is now read-only.
chore(release): migrate to shipjs #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
requested review from
a team,
FabienMotte and
sarahdayan
and removed request for
a team
sarahdayan
reviewed
May 20, 2022
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
dhayab
commented
May 20, 2022
Comment on lines
+127
to
+137
| // Use the `origin-with-token` remote if it exists (when run with Ship.js) | ||
| const origin = execSync( | ||
| `git remote | grep origin-with-token || echo origin` | ||
| ) | ||
| .toString() | ||
| .trim(); | ||
|
|
||
| // Push the new demos to the `templates` branch | ||
| console.log(); | ||
| console.log(`▶︎ Pushing to branch "${chalk.green(TEMPLATES_BRANCH)}"`); | ||
| execSync(`git push origin ${TEMPLATES_BRANCH}`); | ||
| execSync(`git push ${origin} ${TEMPLATES_BRANCH}`); |
Member
Author
There was a problem hiding this comment.
Because the release process is now performed within CircleCI, this modification allows the script to push on the token-authenticated remote Ship.js uses to push the new tag.
I don't know how to test if beforehands though, but it should work. Wdyt @Haroenv @sarahdayan @FabienMotte?
Member
There was a problem hiding this comment.
LGTM, we can always revert if it doesn't work for the next deploy.
sarahdayan
approved these changes
Jun 1, 2022
Haroenv
approved these changes
Jun 1, 2022
FabienMotte
approved these changes
Jun 1, 2022
aymeric-giraudet
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Dec 14, 2022
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the release process from
release-ittoshipjs. It now allows us to prepare a release via a PR, as we do with our other projects.Ticket: FX-1143