Git Version Required for OCR #860
The README said the minimal git version is 2.41. Does this mean there is a issue in the README or some features are specific to git >= 2.41 and cannot function on older git versions? |
Replies: 2 comments 1 reply
|
Note Changes in pull requests 865 does not have any relationship with this discussion. This discussion is only related since the both the topics are about git. |
|
The README is not wrong: Git 2.41 is OCR's supported minimum. OCR does not currently enforce that version at startup, so Git 2.17 can appear to work on this particular staged-workspace path. In That success does not establish full compatibility. On 2.17, the fallback can omit unstaged tracked changes. Range review has no staged fallback, and commit review uses So I would treat the README as the source of truth and upgrade Git to at least 2.41 before relying on OCR's results: git --version
ocr review |
The README is not wrong: Git 2.41 is OCR's supported minimum. OCR does not currently enforce that version at startup, so Git 2.17 can appear to work on this particular staged-workspace path.
In
v1.9.2, workspace review first runsgit diff ... --end-of-options HEAD --. Git 2.17 rejects that command; OCR then falls back togit diff --staged --whenever the first command errors or returns no output. Because your workflow file is staged, that fallback still produces a diff and the review completes. I reproduced this behavior with Git 2.17.0.That success does not establish full compatibility. On 2.17, the fallback can omit unstaged tracked changes. Range review has no staged fallback, and com…