fix(viewer): fix monospace font rendering in pre/code blocks on Windows#328
Merged
Conversation
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes monospace font rendering in
preandcodeblocks on Windows(Chrome & Edge). Closes #325.
Root Cause
Two issues combined to break monospace rendering on Windows:
<pre>and<code>elements had noexplicit
font-familydeclaration, so they inherited thebody'ssans-serif stack (
-apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif)instead of the monospace
--monovariable.--monoCSS variable led withui-monospaceandSFMono-Regular, which are macOS-native aliasesthat don't resolve on Windows. The browser skipped all the way to
the generic
monospacefallback, which renders poorly.Changes
internal/viewer/static/style.csscode, prerule immediately after thebodyblock: