ci(pages): add Pages CI workflow for typecheck and build#442
Merged
Conversation
Add a Pages CI GitHub Actions workflow that runs on pull requests touching pages/**, performing npm ci, typecheck, and build. This provides quality gating for the frontend, which previously had no PR-level checks (deploy-pages.yml only ran on push to main).
Contributor
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+28
to
+30
| - name: Install dependencies | ||
| working-directory: pages | ||
| run: npm ci |
Contributor
There was a problem hiding this comment.
Dependencies are installed via npm ci on every run without any caching. This wastes time and network bandwidth, especially on self-hosted runners. Consider adding caching using actions/cache or the built-in caching in setup-node.
Example:
- uses: actions/setup-node@v4
with:
node-version: '24'
cache: 'npm'
cache-dependency-path: pages/package-lock.jsonThis would replace the container-based Node setup and provide automatic npm caching.
css521
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new
.github/workflows/pages-ci.ymlworkflow that runs on pull requests touchingpages/**. The job installs dependencies withnpm ciand runstypecheckfollowed bybuild.Why
The
pages/frontend previously had no PR-level quality gating. The only existing workflow,deploy-pages.yml, runs solely on push tomain(build + deploy), so type errors and build breakages were only surfaced after merge.This workflow closes that gap by validating the frontend at PR time, reusing the already-present
typecheckscript (tsc --noEmit) that was defined inpackage.jsonbut never wired into CI.Details
pull_requesttomainwith apaths: ['pages/**']filter, so unrelated changes don't run it.npm cifor reproducible, lockfile-pinned installs.self-hostedrunner,node:24container,Trust workspacestep,concurrencywithcancel-in-progress,timeout-minutes).deploy-pages.ymluntouched — this workflow handles quality gating, deploy handles publishing.Scope
This is the first of a planned, incremental rollout of frontend quality gating. Lint/format (ESLint + Prettier) and unit tests (Vitest) are deferred to follow-up PRs.