fix(tool): normalize code comment metadata enums#481
Merged
Conversation
Contributor
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
ousamabenyounes
force-pushed
the
fix/issue-477
branch
from
July 23, 2026 22:17
9ea0460 to
bdf72b7
Compare
Review current changesocr review Review diff between branchesocr review --from main --to feature-auth Review a specific commitocr review --commit abc123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalizes
code_commentcategory and severity values at the parser boundary so undocumented model output does not silently pass through as canonical metadata. Unknown categories fall back toother, unknown severities fall back tolow, valid mixed-case values are canonicalized to lowercase, and the comment content/location are preserved.Type of Change
How Has This Been Tested?
make testpasses locallyTest verification (RED → GREEN)
RED on upstream-base behavior with the new regression test:
RED for the OCR review-bot casing counterexample before the lowercase fix:
GREEN after the fix:
Full local Go CI replay in
golang:1.26.5:Cross-compile check started in
golang:1.26.5and builtlinux/arm64anddarwin/amd64; later targets were blocked by runner disk exhaustion during link (no space left on device).Checklist
go fmt,go vet)Related Issues
Fixes #477