Skip to content

Conversation

@storopoli
Copy link
Contributor

These types are needed to finalize the migration of bitcoind-async-client to use corepc-types.

They are currently being used by Alpen Labs and Payjoin Dev Kit.

I put them in v29 for now, but let me know if we need to put them in previous versions.

@tcharding
Copy link
Member

What are these types used for? By the client to do RPC calls? If so we don't want them in types I'm afraid.

@storopoli
Copy link
Contributor Author

What are these types used for? By the client to do RPC calls? If so we don't want them in types I'm afraid.

Yes, so where should we put them?

@jamillambert
Copy link
Collaborator

I think they should go in /client/src/client_sync/vXX/mod.rs

@storopoli
Copy link
Contributor Author

Ok closing this because my main use case was to implement in an async client and get rid of my custom types.

@storopoli storopoli closed this Oct 3, 2025
@storopoli storopoli deleted the types/v29-additions branch October 3, 2025 17:08
@tcharding
Copy link
Member

These types should stay in your client.

@tcharding
Copy link
Member

I think they should go in /client/src/client_sync/vXX/mod.rs

He isn't using our client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants