Release 1.5.0: Crystal 1.21 support, compatibility chart, GitHub Actions CI - #1400
Merged
Conversation
…build specs - Bump version to 1.5.0 and declare crystal >= 1.20.0 (the constraint >= 1.0.0 overstated what actually compiles). - Add COMPATIBILITY.md documenting which Crystal versions build which Amber releases, with measured results for 1.20.3 and 1.21.0. - Replace the dead CircleCI config's role with a GitHub Actions workflow: spec matrix on Crystal 1.20.3 + latest (Linux) and latest (macOS), plus the postgres-backed granite build spec. CircleCI has been failing at checkout for weeks and every other amberframework repo already runs GitHub Actions. - Fix the generated-app amber dependency rewrite in the spec helpers to use an absolute path: the old ../../../amber literal only resolved when the checkout directory was named amber, so the granite build spec could never pass from a worktree or renamed CI checkout. It also means build specs now exercise the local framework rather than the last released tag. Verified: granite build spec 8/8, main suite 487/0 on 1.21.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Caps off the Crystal 1.21 compatibility work (#1399, #1385, #1386, #1388, #1390, #1391, #1393) with a release:
>= 1.20.0, < 2.0— the old>= 1.0.0overstated what actually compiles.../../../amber, which only resolved when the checkout dir was namedamber; now an absolute path to the checkout under test, so the granite build spec validates local code (previously it silently validated the last released tag).Verification (Crystal 1.21.0)
v2-dev): 2320 examples, 0 failures on both 1.20.3 and 1.21.0 (no changes needed)After merge: tag
v1.5.0+ GitHub release.