Skip to content

Fix controller-relative ECR paths on Windows - #1402

Merged
crimson-knight merged 1 commit into
v2-devfrom
agent/windows-render-path
Aug 11, 2026
Merged

Fix controller-relative ECR paths on Windows#1402
crimson-knight merged 1 commit into
v2-devfrom
agent/windows-render-path

Conversation

@crimson-knight

@crimson-knight crimson-knight commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • normalize compiler source paths before deriving controller-relative view folders
  • add a regression fixture using a Windows controller path
  • keep Unix view resolution unchanged

Evidence

  • crystal spec spec/amber/controller/render_spec.cr: 7 examples, 0 failures
  • full crystal spec: 2,321 examples, 0 failures
  • discovered by the Amber CLI generated-web-app Windows CI job after Crystal, the CLI, generation, dependency installation, and request specs succeeded
  • Amber CLI Windows x86_64 job now passes end to end with this exact commit, including the native application compile: https://github.com/amberframework/amber_cli/actions/runs/31490420518/job/93775339629

Release boundary

Windows is not a beta release gate. The candidate fix is proven in CI, but Amber 2.0.0-beta.2 does not contain it; released Windows support should be claimed only after a later framework beta ships and passes the same generated-app job.

@crimson-knight
crimson-knight marked this pull request as ready for review August 11, 2026 12:20
@crimson-knight
crimson-knight merged commit d044ea0 into v2-dev Aug 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant