Move build test to its own file and test more aspects of build

[marksiemers]

See #348

A big refactor of the specs was done before merging #348 - It was easier to just redo these changes.

[marksiemers]

@amberframework/core-team - These tests will still fail. Based on our discussion of CSRF in the generated controller spec files, it sounds like a fix could go in that will make the tests pass.

In order to get them to pass, there is an issue that needs to be resolved in amber-spec though.

It is fixed here: https://github.com/amberframework/amber-spec/pull/7
But that line change (or other fix) could be incorporated into the other changes happening with amber-spec.

[marksiemers]

Another error has been uncovered. I'm going to comment some lines out, but this will be good to address for a next release (getting this integration test to pass with everything):

 158.     # Cast params and set fields.
 159.     private def cast_to_field(name, value : Type)
 160.       if !value.nil?
 161.         case name.to_s
 162.
 163.           when "user_id"
 164.
>165.               @user_id = value.to_i64
 166.
 167.
 168.           when "post_id"
...
undefined method 'to_i64' for Array(JSON::Type) (compile-time type is (Array(JSON::Type) | Bool | Float64 | Hash(String, JSON::Type) | Int64 | String))

The full trace is here: https://www.zerobin.net/?85f41ce66ae44756#jqdAoilihS2iB+bX7Kdx+poCoa6lIYc17XDKnr3nm+A=

[drujensen]

I think this was fixed here. Need to release granite-orm

[marksiemers]

It seems this integration test will be good at catching bugs introduced by dependencies and/or breaking changes.

[marksiemers]

You'll see that I gutted a lot of what is being tested: 21b1083

If issues are resolved (like @drujensen mentioned), then some of these can be added back in.

The thing that needs to be fixed is the amber-spec constant issue. The thing that can be fixed is the with granite and the JSON casting thing.

@drujensen A couple questions:

1. For the amber-spec - any chance a change will go in to address the same thing as amberframework/amber-spec#7
2. For the granite fix, that is waiting on a release? Any chance of that happening before the next Amber release?

[drujensen]

@marksiemers yeah, i will release it tonight when i get a chance

[eliasjpr]

I can release if that's okay with you @drujensen

[drujensen]

Please do. I’m swamped.

[drujensen]

I released Granite 0.7.6. This should fix the issue with to_i64 against a JSON::Type.

[marksiemers]

@amberframework/core-team - It looks like the change to amber-spec may have an issue. The error in this test is undefined method 'get':

Error in line 1: while requiring "./spec/controllers/animal_controller_spec.cr"

in spec/controllers/animal_controller_spec.cr:18: undefined method 'get'

      get "/animals"
      ^~~

[marksiemers]

If #381 goes in, this can likely be closed, it includes these changes plus more.

[marksiemers]

Done in #381