fix: correct default-weights.yaml dead key, add repomix_config, document branch_protection#407
fix: correct default-weights.yaml dead key, add repomix_config, document branch_protection#407
Conversation
…ent branch_protection - Rename separation_concerns → separation_of_concerns to match the assessor's attribute_id (typo caused the yaml key to never match, overweighting all other attributes slightly) - Add repomix_config: 0.02 (Tier 3); absorb by reducing cyclomatic_complexity and structured_logging each from 0.03 to 0.02, keeping Tier 3 total at 14% - Add comment explaining branch_protection is intentionally omitted until GitHub API integration lands (issue #405) Total still sums to exactly 1.0 across 28 attributes. Closes #403 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Warning
|
| Layer / File(s) | Summary |
|---|---|
Typo Correction & Tier 2 Rebalance src/agentready/data/default-weights.yaml (lines 50–52) |
separation_concerns is renamed to separation_of_concerns with weight 0.03. pattern_references: 0.03 is explicitly included in Tier 2. |
Tier 3 Reweight & Missing Entry src/agentready/data/default-weights.yaml (lines 53–60) |
repomix_config: 0.02 is added to Tier 3 (addressing missing assessor entry from #400). cyclomatic_complexity, structured_logging, and architecture_decisions are reduced from 0.03 to 0.02; openapi_specs remains 0.03. Weights are rebalanced to preserve total of 1.0. |
Tier 4 & Documentation src/agentready/data/default-weights.yaml (lines 61–66) |
Tier 4 weights remain unchanged (code_smells, issue_pr_templates, container_setup, progressive_disclosure at 0.01 each). Comment documents that branch_protection is intentionally omitted as a conditional/API-dependent assessor. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately summarizes the three main changes: typo fix for separation_concerns, addition of repomix_config, and documentation of branch_protection omission. |
| Description check | ✅ Passed | The description clearly explains each change with context, includes verification and test results, and directly references the linked issue. |
| Linked Issues check | ✅ Passed | All three coding objectives from issue #403 are met: separation_concerns typo fixed, repomix_config added to YAML with weight rebalancing, and branch_protection documented with intentional omission justification. |
| Out of Scope Changes check | ✅ Passed | All changes are directly within scope of issue #403 objectives; only src/agentready/data/default-weights.yaml is modified, which is the single file targeted by the linked issue. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/default-weights-yaml
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/agentready/data/default-weights.yaml (1)
3-14:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winStale attribute counts in header block (27 → 28; Tier 3: 5 → 6)
Two header comment counts are now incorrect after adding
repomix_config:
- Line 3: says "27 attributes" — should be 28
- Line 12: says "5 attributes" for Tier 3 — should be 6 (the inline Tier 3 comment at line 53 already says 6, so the header is the odd one out)
📝 Proposed fix
-# This file defines the default weights for all 27 attributes. +# This file defines the default weights for all 28 attributes.-# Tier 3 (Important): 14% total (varies, 5 attributes) +# Tier 3 (Important): 14% total (varies, 6 attributes)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/agentready/data/default-weights.yaml` around lines 3 - 14, Update the header comments in default-weights.yaml to reflect the new attribute counts: change the "27 attributes" to "28" and update "Tier 3: 5 attributes" to "6 attributes" so they match the actual attributes (including the newly added repomix_config) and the inline Tier 3 comment further down; ensure the header totals still read "TOTAL: 100% (sum to 1.0)" unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/agentready/data/default-weights.yaml`:
- Around line 3-14: Update the header comments in default-weights.yaml to
reflect the new attribute counts: change the "27 attributes" to "28" and update
"Tier 3: 5 attributes" to "6 attributes" so they match the actual attributes
(including the newly added repomix_config) and the inline Tier 3 comment further
down; ensure the header totals still read "TOTAL: 100% (sum to 1.0)" unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 21169944-9984-4d7f-9bc2-4d48e1ba3a77
📒 Files selected for processing (1)
src/agentready/data/default-weights.yaml
📈 Test Coverage Report
Coverage calculated from unit tests only |
Header comments said 27 attributes and Tier 3 had 5 attributes. Both are stale after adding repomix_config. Now 28 total, 6 in Tier 3. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 participant
Summary
separation_concerns→separation_of_concernsto matchSeparationOfConcernsAssessor.attribute_id. The old key never matched any assessor, causing it to be dead weight in the yaml while the assessor fell back todefault_weight=0.03.repomix_config: 0.02: makes the weight explicit in the yaml now that the assessor is registered (see Fix failing e2e test: repomix_config not registered in create_all_assessors #400). Weight absorbed within Tier 3 by reducingcyclomatic_complexityandstructured_loggingfrom 0.03 to 0.02 each — Tier 3 total stays at 14%.branch_protection: add a comment explaining it is intentionally omitted until GitHub API integration is implemented (see Implement BranchProtectionAssessor using GitHub API #405).Verification
Test plan
python3 -c "import yaml; ..."confirms weights sum to exactly 1.0Closes #403
🤖 Generated with Claude Code under the supervision of Bill Murdock