Skip to content

docs: describe partial-credit pass range for dependency_security - #541

Merged
jwm4 merged 1 commit into
ambient-code:mainfrom
jwm4:docs/dependency-security-threshold
Sep 4, 2026
Merged

docs: describe partial-credit pass range for dependency_security#541
jwm4 merged 1 commit into
ambient-code:mainfrom
jwm4:docs/dependency-security-threshold

Conversation

@jwm4

@jwm4 jwm4 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

The dependency_security entry in docs/attributes.md stated a flat "Pass threshold: 60 points," but DependencySecurityAssessor in src/agentready/assessors/security.py passes any score of 30 or higher. Scores of 30-59 are partial-credit passes with remediation guidance attached to the finding, and only scores below 30 fail.

This updates the docs to describe the actual behavior:

  • 60+ points: full pass
  • 30-59 points: pass with partial credit, remediation guidance included
  • Below 30: fail

Docs-only change; no assessor behavior is modified.

This PR was created by Bill Murdock with assistance from Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated Dependency Security scoring guidance to clarify full-pass, partial-credit, and failing score ranges.
    • Added remediation guidance for scores receiving partial credit.

The dependency_security section claimed a flat pass threshold of 60
points, but DependencySecurityAssessor passes any score >= 30: scores
of 30-59 pass with partial credit and attached remediation, and only
scores below 30 fail. Update docs/attributes.md to match the code.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 7abf7741-52a0-43c4-bc20-18b4a73c3353

📥 Commits

Reviewing files that changed from the base of the PR and between 3825195 and 133f69b.

📒 Files selected for processing (1)
  • docs/attributes.md

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Dependency Security documentation now defines three score bands: full pass, partial credit with remediation guidance, and failure.

Changes

Dependency Security documentation

Layer / File(s) Summary
Document scoring bands
docs/attributes.md
The pass threshold now states that scores of 60+ fully pass, scores of 30–59 pass with partial credit and remediation guidance, and scores below 30 fail.

Merge Risk: ⚪ Minimal · up to 133f6

Dependency Security documentation now clearly describes full-pass, partial-credit, and failing score bands. No remaining merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the allowed docs type and accurately describes the documentation update for the dependency_security partial-credit pass range.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

📈 Test Coverage Report

Branch Coverage
This PR 76.4%
Main 76.4%
Diff ✅ +0%

Coverage calculated from unit tests only

@jwm4
jwm4 merged commit fdc9dbe into ambient-code:main Sep 4, 2026
6 checks passed
@jwm4
jwm4 deleted the docs/dependency-security-threshold branch September 4, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant