Tolerate deallocation of statements the server has already dropped - #74
Open
webpatser wants to merge 1 commit into
Open
Tolerate deallocation of statements the server has already dropped#74webpatser wants to merge 1 commit into
webpatser wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to amphp/sql-common#8. Deallocating a prepared statement can race the pool's
DISCARD ALLconnection reset:DISCARD ALLdrops every server-side prepared statement, so the queuedDEALLOCATEfor a statement closed just before the connection was reset fails withprepared statement "..." does not exist.Two problems fall out of that on the pgsql backend:
DEALLOCATEran throughquery(), so its error result went throughcreateResult(). The fatal-error branch there drains the connection (while (pg_connection_busy && pg_get_result)), which can consume responses belonging to an operation dispatched after the deallocation. That operation then awaits a reply that never comes, wedging the connection permanently. With sql-common#8 in place (declined statements are closed), this shape reproduces deterministically:Fix: send the
DEALLOCATEwithout routing it through result processing and tolerate failure on both backends; the statement being gone is the desired end state either way. The statement cache entry is now removed regardless of the outcome.The new
StatementDeallocateTestexercises deallocation racingDISCARD ALLon a single-connection pool; the deterministic wedge above needs sql-common#8 to trigger, so it is documented here rather than encoded as a test that would fail against the current sql-common release.Test run: 121 PgSql tests + the new test green against PostgreSQL 16 (pq suite skipped, ext-pq unavailable locally).