Skip to content

fix(@angular-devkit/build-angular): show warning when using TypeScript target older then ES2022 in esbuild builder#23949

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:esbuild-warning-ts-target-old
Oct 11, 2022
Merged

fix(@angular-devkit/build-angular): show warning when using TypeScript target older then ES2022 in esbuild builder#23949
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:esbuild-warning-ts-target-old

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

This commits adds a warning similar to that in the Webpack builder.

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2022
@alan-agius4 alan-agius4 marked this pull request as draft September 23, 2022 13:11
@alan-agius4 alan-agius4 force-pushed the esbuild-warning-ts-target-old branch 2 times, most recently from a808885 to b0d5dac Compare September 26, 2022 12:51
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 26, 2022
@alan-agius4 alan-agius4 requested a review from clydin September 26, 2022 12:58
@alan-agius4 alan-agius4 marked this pull request as ready for review September 26, 2022 12:58
@alan-agius4 alan-agius4 force-pushed the esbuild-warning-ts-target-old branch 2 times, most recently from a72573f to 4d4f9f7 Compare September 27, 2022 08:42
@alan-agius4 alan-agius4 added this to the v15 Feature Freeze milestone Oct 7, 2022
@alan-agius4 alan-agius4 force-pushed the esbuild-warning-ts-target-old branch from 4d4f9f7 to 541355d Compare October 7, 2022 10:08
@alan-agius4 alan-agius4 force-pushed the esbuild-warning-ts-target-old branch from 541355d to 0a196f8 Compare October 11, 2022 14:11
@alan-agius4 alan-agius4 reopened this Oct 11, 2022
notes: [
{
text: `To control ECMA version and features use the Browerslist configuration. ' +
'For more information, see https://github.com/browserslist/browsers§list'`,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'For more information, see https://github.com/browserslist/browsers§list'`,
'For more information, see https://github.com/browserslist/browserslist#queries'`,

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 11, 2022
…t target older then ES2022 in esbuild builder

This commits adds a warning similar to that in the Webpack builder.
@alan-agius4 alan-agius4 force-pushed the esbuild-warning-ts-target-old branch from 9459cde to 61cef0e Compare October 11, 2022 14:46
@alan-agius4 alan-agius4 merged commit 6c3f281 into angular:main Oct 11, 2022
@alan-agius4 alan-agius4 deleted the esbuild-warning-ts-target-old branch October 11, 2022 14:46
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants