Skip to content

fix(@angular-devkit/build-angular): show warning when using TypeScript target older then ES2022 in esbuild builder #23949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Oct 11, 2022
Merged

fix(@angular-devkit/build-angular): show warning when using TypeScript target older then ES2022 in esbuild builder #23949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ export function createCompilerPlugin(
name: 'angular-compiler',
// eslint-disable-next-line max-lines-per-function
async setup(build: PluginBuild): Promise<void> {
let setupWarnings: PartialMessage[] | undefined;

// This uses a wrapped dynamic import to load `@angular/compiler-cli` which is ESM.
// Once TypeScript provides support for retaining dynamic imports this workaround can be dropped.
const compilerCli = await loadEsmModule<typeof import('@angular/compiler-cli')>(
Expand Down Expand Up @@ -223,7 +225,19 @@ export function createCompilerPlugin(
// which breaks the deprecated `@Effects` NGRX decorator and potentially other existing code as well.
compilerOptions.target = ts.ScriptTarget.ES2022;
compilerOptions.useDefineForClassFields ??= false;
// TODO: show warning about this override when we have access to the logger.

(setupWarnings ??= []).push({
text:
'TypeScript compiler options "target" and "useDefineForClassFields" are set to "ES2022" and ' +
'"false" respectively by the Angular CLI.',
location: { file: pluginOptions.tsconfig },
notes: [
{
text: `To control ECMA version and features use the Browerslist configuration. ' +
'For more information, see https://github.com/browserslist/browserslist#queries'`,
},
],
});
}

// The file emitter created during `onStart` that will be used during the build in `onLoad` callbacks for TS files
Expand All @@ -237,7 +251,12 @@ export function createCompilerPlugin(
const babelDataCache = new Map<string, string>();

build.onStart(async () => {
const result: OnStartResult = {};
const result: OnStartResult = {
warnings: setupWarnings,
};

// Reset the setup warnings so that they are only shown during the first build.
setupWarnings = undefined;

// Reset debug performance tracking
resetCumulativeDurations();
Expand Down