Add functional router guards and resolvers by atscott · Pull Request #24170 · angular/angular-cli

atscott · 2022-11-02T15:26:42Z

Functional guards and resolvers were introduced in the Angular router in v14.2.

This commit adds the ability to generate functional router guards by specifying --guardType instead of --implements. These guards are also accompanied by a test that includes a helper function for executing the guard in the TestBed environment so that any inject calls in the guard will work properly. Functional resolvers are generated by adding the --functional flag.

alan-agius4

I am concerned that this is happing outside of a major version. As there are 2 changes in behaviour here which technically are breaking changes.

atscott · 2022-11-03T14:44:40Z

I am concerned that this is happing outside of a major version. As there are 2 changes in behaviour here which technically are breaking changes.

I don't know what the CLI team considers breaking, so you'll have to help determine what we're allowed to do here. I assumed, maybe incorrectly, that keeping all the options the same but changing the defaults would be fine.

alan-agius4 · 2022-11-04T06:37:26Z

        "type": "string"
      },
-      "default": ["CanActivate"],
      "x-prompt": "Which interfaces would you like to implement?"


I think the prompt in this case should be removed. Since otherwise there wouldn't be a way to use guardType.

I'm assuming there's not a way to make the prompt conditional? I feel like the lack of a prompt is a step down in UX.

Correct. we don't support conditional prompts.

So I tried this out and I don't think this is going to work. The experience now is that ng g guard myGuard will just generate a canActivate guard automatically. Most users will not know about the implements flag and will not know how to generate a guard of another type. We'll have to come up with another way to make this work.

Okay, I updated the approach to use the --functional flag and throw an error if there is more than 1 value for implements when using it. The names of the existing implements options are the interfaces, and while this isn't ideal, I don't think it's really an issue.

PTAL

alan-agius4

LGTM, one little nit.

…outer guards and resolvers Functional guards and resolvers were introduced in the Angular router in v14.2. This commit adds the ability to generate functional router guards by specifying `--guardType` instead of `--implements`. These guards are also accompanied by a test that includes a helper function for executing the guard in the `TestBed` environment so that any `inject` calls in the guard will work properly. Functional resolvers are generated by adding the `--functional` flag.

…ional router guards and resolvers

alan-agius4

LGTM

angular-automatic-lock-bot · 2022-12-10T08:04:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

atscott added the target: minor This PR is targeted for the next minor release label Nov 2, 2022

angular-robot bot added the detected: feature PR contains a feature commit label Nov 2, 2022

atscott changed the title ~~Functional guards and resolvers~~ Add functional router guards Nov 2, 2022

atscott changed the title ~~Add functional router guards~~ Add functional router guards and resolvers Nov 2, 2022

atscott force-pushed the functionalGuardsAndResolvers branch 2 times, most recently from f3c8edf to 1a11ea1 Compare November 2, 2022 19:44

atscott requested a review from alan-agius4 November 2, 2022 19:54