Update defaults for guards and resolvers to be functional guards#24182
Closed
atscott wants to merge 4 commits intoangular:mainfrom
Closed
Update defaults for guards and resolvers to be functional guards#24182atscott wants to merge 4 commits intoangular:mainfrom
atscott wants to merge 4 commits intoangular:mainfrom
Conversation
…outer guards Functional guards were introduced in the Angular router in v14.2. This commit adds the ability to generate functional router guards by specifying `--guardType` instead of `--implements`. These guards are also accompanied by a test that includes a helper function for executing the guard in the `TestBed` environment so that any `inject` calls in the guard will work properly. DEPRECATED: The 'implements' flag is deprecated. Use 'guardType' instead.
…outer resolvers Functional resolvers were introduced in the Angular router in v14.2. This commit adds the ability to generate functional router resolvers by specifying `--functional`. These resolvers are also accompanied by a test that includes a helper function for executing the resolver in the `TestBed` environment so that any `inject` calls in the resolver will work properly.
This commit updates the guard schematic to prompt for the type of guard to generate rather than the interface. This will generate a functional guard. Class-based guards will be deprecated in v15.1: angular/angular#47924
This commit updates the resolver schematic to generate functional resolvers by defualt. Class-based resolvers will be deprecated in v15.1: angular/angular#47924
atscott
added
state: blocked
target: major
angular-robot
bot
added
detected: deprecation
alan-agius4
added
the
needs: discussion
Collaborator
|
Hi @atscott, We did discuss this PR during our last triage meeting and while we do not guarantee that the generated code does not change between versions. This is too big of a change to be done outside of a major. We suggest a call out in the deprecation note so users can opt-in and use the non deprecated code template by default Feel free to close the PR or rebase it and make the necessary changes to eventually land in v16. I also have a separate PR to add an aliased for the |
alan-agius4
added
action: cleanup
Collaborator
|
Closing in favor of #24585 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first two commits are part of #24170.
The two commits specific to this are the default updates, which may be considered a breaking change.