fix(@angular/build): builder removes @angular/localize when external packages are not inlined

[roma-claudio]

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

@angular/localize scripts are always removed when inline transformations are enabled, even though not all the scripts/dependencies might have been transformed

Issue Number: N/A

What is the new behavior?

@angular/localize scripts will only be removed when inline transformations are enabled and all the scripts/dependencies are actually transformed

Does this PR introduce a breaking change?

• Yes
• No

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[alan-agius4]

I'm a bit confused by the description of this change. i18n inlining is controlled by the localize option and happens regardless of the optimization setting.

Currently, @angular/localize is already removed only when inlining is required https://github.com/roma-claudio/angular-cli/blob/c3c9ac5067275461e2d8caefba81ac9701949776/packages/angular/build/src/tools/esbuild/application-code-bundle.ts#L674-L675 as otherwise it will be required as a runtime dependency irrespective of the optimization option value.

[roma-claudio]

Hi @alan-agius4

Apologies for the misleading reference, at first I thought that I'd check if there are Vite's pre-bundles dependencies (which are not inlined) by looking at the optimized script presence.

Now let me clarify the issue that I've found:

The i18n inliner processes executionResult.outputFiles which from what I've seen do not include Vite's pre-bundled dependencies.
If the polyfills localize is removed, those dependencies which contains $localize will fail to execute.

Ideally, the localize script should only be removed if there are no pre-bundled dependencies containing $localize.
I'm looking for a way to check for this condition before removing or not the import 💭

What do you think?

[alan-agius4]

Oh I now understand the problem, but for that case, using the optimization option is not the correct approach. In addition as a workaround you could also exclude these deps from bring pre-bundled. Using the dev-server prebundle.exclude option.

[alan-agius4]

Kindly sign the CLA as otherwise we'll be unable to accept this change. Also please update the commit message to reflect the change and include a body with a description in the commit.

Thanks.

[roma-claudio]

Thanks @alan-agius4

Code updated 👍🏻

[alan-agius4]

LGTM, thanks for this.

[alan-agius4]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 38c2200
• 20.3.x: b3908f6
• 21.0.x: f82b77e