Skip to content

fix(@angular/build): builder removes @angular/localize when external packages are not inlined #31721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

fix(@angular/build): builder removes @angular/localize when external packages are not inlined #31721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/angular/build/src/tools/esbuild/application-code-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ function getEsBuildCommonPolyfillsOptions(
tryToResolvePolyfillsAsRelative: boolean,
loadResultCache: LoadResultCache | undefined,
): BuildOptions | undefined {
const { jit, workspaceRoot, i18nOptions } = options;
const { jit, workspaceRoot, i18nOptions, externalPackages } = options;

const buildOptions = getEsBuildCommonOptions(options);
buildOptions.splitting = false;
Expand All @@ -671,8 +671,10 @@ function getEsBuildCommonPolyfillsOptions(
// Locale data should go first so that project provided polyfill code can augment if needed.
let needLocaleDataPlugin = false;
if (i18nOptions.shouldInline) {
// Remove localize polyfill as this is not needed for build time i18n.
polyfills = polyfills.filter((path) => !path.startsWith('@angular/localize'));
if (!externalPackages) {
// Remove localize polyfill when i18n inline transformation have been applied to all the packages.
polyfills = polyfills.filter((path) => !path.startsWith('@angular/localize'));
}

// Add locale data for all active locales
// TODO: Inject each individually within the inlining process itself
Expand Down
Loading