fix(@angular/ssr): destroy platform when response stream is cancelled - #33802
Merged
alan-agius4 merged 1 commit intoAug 7, 2026
Merged
Conversation
alan-agius4
force-pushed
the
fix-ssr-stream-cancel-cleanup
branch
from
August 7, 2026 14:24
b677ace to
1d0f4f3
Compare
alan-agius4
marked this pull request as ready for review
August 7, 2026 14:25
alan-agius4
added
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces robust error handling and resource cleanup for the Angular SSR response stream. It wraps the stream's start method in a try-catch block, handles stream cancellation by destroying the rendering result, and exposes a destroy callback from renderAngular to clean up the platform reference. The reviewer suggested adding a unit test to verify that the platform is properly destroyed when the response stream is cancelled, providing a code snippet for the test.
alan-agius4
force-pushed
the
fix-ssr-stream-cancel-cleanup
branch
from
August 7, 2026 14:28
1d0f4f3 to
bd73ca5
Compare
Ensures PlatformRef is properly destroyed when an active response stream is cancelled or encounters an error during rendering to prevent memory leaks.
alan-agius4
force-pushed
the
fix-ssr-stream-cancel-cleanup
branch
from
August 7, 2026 14:30
bd73ca5 to
413feed
Compare
clydin
approved these changes
Aug 7, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures PlatformRef is properly destroyed when an active response stream is cancelled or encounters an error during rendering to prevent memory leaks.