test(@angular/build): avoid race conditions in incremental-watch e2e test - #33815
Merged
clydin merged 1 commit intoAug 7, 2026
Merged
Conversation
…test
Remove an extraneous `await` inside the `Promise.all` array literal in `incremental-watch.ts` that caused `writeFile('src/a.ts')` to execute sequentially before `appendToFile('src/main.ts')`, triggering an unintended intermediate rebuild.
Additionally, replace static `setTimeout(500)` delays with a deterministic polling helper `getOutputFiles` to prevent ENOENT errors when reading the output directory before file emission completes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function getOutputFiles in tests/e2e/tests/build/incremental-watch.ts to replace arbitrary timeouts with a polling mechanism that waits for output files to match a predicate. It also removes an unnecessary await inside a Promise.all call. The feedback suggests handling potential ENOENT errors when reading the directory after a timeout to ensure the assertion fails with a descriptive message instead of throwing an unhandled exception.
clydin
added
the
action: review
alan-agius4
approved these changes
Aug 7, 2026
alan-agius4
added
action: merge
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove an extraneous
awaitinside thePromise.allarray literal inincremental-watch.tsthat causedwriteFile('src/a.ts')to execute sequentially beforeappendToFile('src/main.ts'), triggering an unintended intermediate rebuild.Additionally, replace static
setTimeout(500)delays with a deterministic polling helpergetOutputFilesto prevent ENOENT errors when reading the output directory before file emission completes.