Skip to content

Windows 10 Bash bug fix for issue #3028 - #4166

Closed
sagea wants to merge 2 commits into
angular:masterfrom
sagea:master
Closed

Windows 10 Bash bug fix for issue #3028#4166
sagea wants to merge 2 commits into
angular:masterfrom
sagea:master

Conversation

@sagea

@sagea sagea commented Jan 22, 2017

Copy link
Copy Markdown

Updating portfinder dependency from @1.0.9 to @1.0.12 to fix windows 10 bash bug. Look at issue #3028 for more information.

#3028

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@sagea

sagea commented Jan 22, 2017

Copy link
Copy Markdown
Author

Test Results: (Ran on Windows 10 bash.)

123 passing (46s)
5 pending

Reading dependencies of "@angular-cli/ast-tools".
found 4 dependencies...
no dependency missing from package.json.
no excessive dependencies in package.json.

Reading dependencies of "@angular-cli/base-href-webpack".
found 0 dependencies...
no dependency missing from package.json.
no excessive dependencies in package.json.

Reading dependencies of "@ngtools/json-schema".
found 0 dependencies...
no dependency missing from package.json.
no excessive dependencies in package.json.

Reading dependencies of "@ngtools/logger".
found 1 dependencies...
no dependency missing from package.json.
no excessive dependencies in package.json.

Reading dependencies of "@ngtools/webpack".
found 10 dependencies...
no dependency missing from package.json.
no excessive dependencies in package.json.

Reading dependencies of "angular-cli".
found 71 dependencies...
no dependency missing from package.json.
no excessive dependencies in package.json.

Validating root package. [devDependencies ignored]
no dependency missing from package.json.
no excessive dependencies in package.json.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@filipesilva filipesilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also change it in https://github.com/angular/angular-cli/blob/master/packages/@angular/cli/package.json.

Other than that, lgtm when rebased.

@filipesilva

Copy link
Copy Markdown
Contributor

This was closed meanwhile via #4546

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants