Windows 10 Bash bug fix for issue #3028 - #4166
Conversation
…10 bash bug. Look at issue angular#3028 for more information.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Test Results: (Ran on Windows 10 bash.) 123 passing (46s) Reading dependencies of "@angular-cli/ast-tools". Reading dependencies of "@angular-cli/base-href-webpack". Reading dependencies of "@ngtools/json-schema". Reading dependencies of "@ngtools/logger". Reading dependencies of "@ngtools/webpack". Reading dependencies of "angular-cli". Validating root package. [devDependencies ignored] |
|
CLAs look good, thanks! |
filipesilva
left a comment
There was a problem hiding this comment.
You need to also change it in https://github.com/angular/angular-cli/blob/master/packages/@angular/cli/package.json.
Other than that, lgtm when rebased.
|
This was closed meanwhile via #4546 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updating portfinder dependency from @1.0.9 to @1.0.12 to fix windows 10 bash bug. Look at issue #3028 for more information.
#3028