Account for different defaults values of the @Component standalone option based on Angular version

[DallasHoff]

🐞 bug report

Is this a regression?

Yes, the previous version in which this bug was not present was: 18.2.0

Description

When used on a project that has not upgraded to Angular 19, any components that are not standalone and do not set the standalone option to false in the component are highlighted in HTML files with the example-component-selector is not a known element error.

The default value for standalone was changed from false to true in Angular 19, but this extension should use false as the default value if the installed Angular version is less than 19.

Bug Type

What does this bug affect

• Angular Language Service VSCode extension
• Angular Language Service server

Reproduction

On an Angular version <19, create a non-standalone component with no usage of the standalone option in @Component, and attempt to use it inside another component. The app will compile just fine, but the language server will report that the component used is not known.

🌍 Your Environment

Angular Version:

Angular CLI: 18.2.9
Node: 18.20.4
Package Manager: npm 10.7.0
OS: win32 x64

Angular: 18.2.8
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1802.9
@angular-devkit/build-angular   18.2.9
@angular-devkit/core            18.2.9
@angular-devkit/schematics      18.2.9
@angular/cli                    18.2.9
@schematics/angular             18.2.9
rxjs                            6.6.7
typescript                      5.5.4
zone.js                         0.14.10

Extension Version: 19.0.0

[alxhub]

Hi @DallasHoff,

Can you please share your Angular Language Service log:

Set the Angular Log level to verbose by opening settings (File/Preferences/Settings on Windows, Code/Preferences/Settings on Mac), go to Extensions/Angular Language Service, set angular.log to verbose.

To open the log file, go to the command palette (Cmd+Shift+P on Mac, Ctrl+Shift+P on Windows), search Open Angular Server log.

Alternatively, if the log file is long, it can be uploaded instead of pasting below.

[invaderb]

I'm also getting the error after updating to the latest version

Component TestAlertComponent is standalone, and cannot be declared in an NgModule. Did you mean to import it instead?(-996008)

However none of my components are standalone

Trace - 1:01:07 PM] Sending request 'initialize - (0)'.
Params: {
    "processId": 48230,
    "clientInfo": {
        "name": "Visual Studio Code",
        "version": "1.95.1"
    },
    "locale": "en-us",
    "rootPath": "/app",
    "rootUri": "file:///app",
    "capabilities": {
        "workspace": {
            "applyEdit": true,
            "workspaceEdit": {
                "documentChanges": true,
                "resourceOperations": [
                    "create",
                    "rename",
                    "delete"
                ],
                "failureHandling": "textOnlyTransactional",
                "normalizesLineEndings": true,
                "changeAnnotationSupport": {
                    "groupsOnLabel": true
                }
            },
            "didChangeConfiguration": {
                "dynamicRegistration": true
            },
            "didChangeWatchedFiles": {
                "dynamicRegistration": true
            },
            "symbol": {
                "dynamicRegistration": true,
                "symbolKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25,
                        26
                    ]
                },
                "tagSupport": {
                    "valueSet": [
                        1
                    ]
                }
            },
            "codeLens": {
                "refreshSupport": true
            },
            "executeCommand": {
                "dynamicRegistration": true
            },
            "configuration": true,
            "workspaceFolders": true,
            "semanticTokens": {
                "refreshSupport": true
            },
            "fileOperations": {
                "dynamicRegistration": true,
                "didCreate": true,
                "didRename": true,
                "didDelete": true,
                "willCreate": true,
                "willRename": true,
                "willDelete": true
            }
        },
        "textDocument": {
            "publishDiagnostics": {
                "relatedInformation": true,
                "versionSupport": false,
                "tagSupport": {
                    "valueSet": [
                        1,
                        2
                    ]
                },
                "codeDescriptionSupport": true,
                "dataSupport": true
            },
            "synchronization": {
                "dynamicRegistration": true,
                "willSave": true,
                "willSaveWaitUntil": true,
                "didSave": true
            },
            "completion": {
                "dynamicRegistration": true,
                "contextSupport": true,
                "completionItem": {
                    "snippetSupport": true,
                    "commitCharactersSupport": true,
                    "documentationFormat": [
                        "markdown",
                        "plaintext"
                    ],
                    "deprecatedSupport": true,
                    "preselectSupport": true,
                    "tagSupport": {
                        "valueSet": [
                            1
                        ]
                    },
                    "insertReplaceSupport": true,
                    "resolveSupport": {
                        "properties": [
                            "documentation",
                            "detail",
                            "additionalTextEdits"
                        ]
                    },
                    "insertTextModeSupport": {
                        "valueSet": [
                            1,
                            2
                        ]
                    }
                },
                "completionItemKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25
                    ]
                }
            },
            "hover": {
                "dynamicRegistration": true,
                "contentFormat": [
                    "markdown",
                    "plaintext"
                ]
            },
            "signatureHelp": {
                "dynamicRegistration": true,
                "signatureInformation": {
                    "documentationFormat": [
                        "markdown",
                        "plaintext"
                    ],
                    "parameterInformation": {
                        "labelOffsetSupport": true
                    },
                    "activeParameterSupport": true
                },
                "contextSupport": true
            },
            "definition": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "references": {
                "dynamicRegistration": true
            },
            "documentHighlight": {
                "dynamicRegistration": true
            },
            "documentSymbol": {
                "dynamicRegistration": true,
                "symbolKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25,
                        26
                    ]
                },
                "hierarchicalDocumentSymbolSupport": true,
                "tagSupport": {
                    "valueSet": [
                        1
                    ]
                },
                "labelSupport": true
            },
            "codeAction": {
                "dynamicRegistration": true,
                "isPreferredSupport": true,
                "disabledSupport": true,
                "dataSupport": true,
                "resolveSupport": {
                    "properties": [
                        "edit"
                    ]
                },
                "codeActionLiteralSupport": {
                    "codeActionKind": {
                        "valueSet": [
                            "",
                            "quickfix",
                            "refactor",
                            "refactor.extract",
                            "refactor.inline",
                            "refactor.rewrite",
                            "source",
                            "source.organizeImports"
                        ]
                    }
                },
                "honorsChangeAnnotations": false
            },
            "codeLens": {
                "dynamicRegistration": true
            },
            "formatting": {
                "dynamicRegistration": true
            },
            "rangeFormatting": {
                "dynamicRegistration": true
            },
            "onTypeFormatting": {
                "dynamicRegistration": true
            },
            "rename": {
                "dynamicRegistration": true,
                "prepareSupport": true,
                "prepareSupportDefaultBehavior": 1,
                "honorsChangeAnnotations": true
            },
            "documentLink": {
                "dynamicRegistration": true,
                "tooltipSupport": true
            },
            "typeDefinition": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "implementation": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "colorProvider": {
                "dynamicRegistration": true
            },
            "foldingRange": {
                "dynamicRegistration": true,
                "rangeLimit": 5000,
                "lineFoldingOnly": true
            },
            "declaration": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "selectionRange": {
                "dynamicRegistration": true
            },
            "callHierarchy": {
                "dynamicRegistration": true
            },
            "semanticTokens": {
                "dynamicRegistration": true,
                "tokenTypes": [
                    "namespace",
                    "type",
                    "class",
                    "enum",
                    "interface",
                    "struct",
                    "typeParameter",
                    "parameter",
                    "variable",
                    "property",
                    "enumMember",
                    "event",
                    "function",
                    "method",
                    "macro",
                    "keyword",
                    "modifier",
                    "comment",
                    "string",
                    "number",
                    "regexp",
                    "operator"
                ],
                "tokenModifiers": [
                    "declaration",
                    "definition",
                    "readonly",
                    "static",
                    "deprecated",
                    "abstract",
                    "async",
                    "modification",
                    "documentation",
                    "defaultLibrary"
                ],
                "formats": [
                    "relative"
                ],
                "requests": {
                    "range": true,
                    "full": {
                        "delta": true
                    }
                },
                "multilineTokenSupport": false,
                "overlappingTokenSupport": false
            },
            "linkedEditingRange": {
                "dynamicRegistration": true
            }
        },
        "window": {
            "showMessage": {
                "messageActionItem": {
                    "additionalPropertiesSupport": true
                }
            },
            "showDocument": {
                "support": true
            },
            "workDoneProgress": true
        },
        "general": {
            "regularExpressions": {
                "engine": "ECMAScript",
                "version": "ES2020"
            },
            "markdown": {
                "parser": "marked",
                "version": "1.1.0"
            }
        }
    },
    "trace": "verbose",
    "workspaceFolders": [
        {
            "uri": "file:///app",
            "name": "ems"
        }
    ]
}


[Trace - 1:01:08 PM] Received notification 'window/logMessage'.
Params: {
    "type": 3,
    "message": "Angular language server process ID: 49174"
}


[Info  - 1:01:08 PM] Angular language server process ID: 49174
[Trace - 1:01:08 PM] Received notification 'window/logMessage'.
Params: {
    "type": 3,
    "message": "Imported typescript/lib/tsserverlibrary is version 5.6.2."
}


[Info  - 1:01:08 PM] Imported typescript/lib/tsserverlibrary is version 5.6.2.
[Trace - 1:01:08 PM] Received notification 'window/logMessage'.
Params: {
    "type": 3,
    "message": "Using @angular/language-service v19.0.0-rc.1 from /.vscode/extensions/angular.ng-template-19.0.0/node_modules/@angular/language-service/index.js"
}


[Info  - 1:01:08 PM] Using @angular/language-service v19.0.0-rc.1 from /.vscode/extensions/angular.ng-template-19.0.0/node_modules/@angular/language-service/index.js
[Trace - 1:01:08 PM] Received notification 'window/logMessage'.
Params: {
    "type": 3,
    "message": "Log file: /Library/Application Support/Code/logs/20241107T101752/window3/exthost/Angular.ng-template/nglangsvc.log"
}


[Info  - 1:01:08 PM] Log file: /Library/Application Support/Code/logs/20241107T101752/window3/exthost/Angular.ng-template/nglangsvc.log
[Trace - 1:01:08 PM] Received response 'initialize - (0)' in 343ms.
Result: {
    "capabilities": {
        "foldingRangeProvider": true,
        "codeLensProvider": {
            "resolveProvider": true
        },
        "textDocumentSync": 2,
        "completionProvider": {
            "resolveProvider": true,
            "triggerCharacters": [
                "<",
                ".",
                "*",
                "[",
                "(",
                "$",
                "|",
                "@"
            ]
        },
        "definitionProvider": true,
        "typeDefinitionProvider": true,
        "referencesProvider": true,
        "renameProvider": {
            "prepareProvider": true
        },
        "hoverProvider": true,
        "signatureHelpProvider": {
            "triggerCharacters": [
                "(",
                ","
            ],
            "retriggerCharacters": [
                ","
            ]
        },
        "workspace": {
            "workspaceFolders": {
                "supported": true
            }
        },
        "codeActionProvider": {
            "resolveProvider": true,
            "codeActionKinds": [
                "quickfix"
            ]
        }
    },
    "serverOptions": {
        "logFile": "/Library/Application Support/Code/logs/20241107T101752/window3/exthost/Angular.ng-template/nglangsvc.log"
    }
}


[Trace - 1:01:08 PM] Sending notification 'initialized'.
Params: {}


[Trace - 1:01:08 PM] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "file:///app/ui/src/app/modules/admin/admin.module.ts",
        "languageId": "typescript",
        "version": 11,
        "text": "import { NgModule } from '@angular/core';\nimport { CommonModule } from '@angular/common';\nimport { FormsModule, ReactiveFormsModule } from '@angular/forms';\nimport { MaterialModule } from 'src/app/material.module';\nimport { TestAlertComponent } from './components/test-alert/test-alert.component';\n\nimport { AdminRoutingModule } from './admin-routing.modules';\nimport { AdminComponent } from './admin.component';\nimport { RolePermissionsComponent } from './components/role-permissions/role-permissions.component';\nimport { RolePermissionDialogComponent } from './components/role-permission-dialog/role-permission-dialog.component';\n\n@NgModule({\n\tdeclarations: [TestAlertComponent, AdminComponent, RolePermissionsComponent, RolePermissionDialogComponent],\n\timports: [CommonModule, MaterialModule, FormsModule, AdminRoutingModule, ReactiveFormsModule, MaterialModule]\n})\nexport class AdminModule {}\n"
    }
}


[Trace - 1:01:08 PM] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "file:///app/ui/src/app/modules/admin/components/test-alert/test-alert.component.ts",
        "languageId": "typescript",
        "version": 25,
        "text": "import { Component, inject } from '@angular/core';\nimport { FormBuilder, FormGroup } from '@angular/forms';\nimport { MAT_DIALOG_DATA } from '@angular/material/dialog';\nimport { AlertService } from 'src/app/services/alert.service';\n\n@Component({\n\tselector: 'app-test-alert',\n\ttemplate: `\n\t\t<h2 mat-dialog-title>Test Alert</h2>\n\t\t<mat-dialog-content class=\"mat-typography\">\n\t\t\t<form [formGroup]=\"form\" class=\"margin-top--8 margin-bottom--8 flex flex-column flex-space-between gap-8\">\n\t\t\t\t<!-- Message -->\n\t\t\t\t<mat-form-field appearance=\"fill\" color=\"accent\" class=\"width-100\" subscriptSizing=\"dynamic\">\n\t\t\t\t\t<mat-label>Message</mat-label>\n\t\t\t\t\t<textarea\n\t\t\t\t\t\tmatInput\n\t\t\t\t\t\tplaceholder=\"Message\"\n\t\t\t\t\t\tformControlName=\"message\"\n\t\t\t\t\t\tmatTextareaAutosize\n\t\t\t\t\t\tmatAutosizeMinRows=\"3\"\n\t\t\t\t\t\tmatAutosizeMaxRows=\"5\"\n\t\t\t\t\t>\n\t\t\t\t\t</textarea>\n\t\t\t\t</mat-form-field>\n\t\t\t\t<!-- Snackbar Type -->\n\t\t\t\t<mat-form-field appearance=\"fill\" color=\"accent\" class=\"width-100\" subscriptSizing=\"dynamic\">\n\t\t\t\t\t<mat-label>Snackbar Type</mat-label>\n\t\t\t\t\t<mat-select formControlName=\"snackType\">\n\t\t\t\t\t\t<mat-option value=\"Success\">Success</mat-option>\n\t\t\t\t\t\t<mat-option value=\"Error\">Error</mat-option>\n\t\t\t\t\t\t<mat-option value=\"Warn\">Warn</mat-option>\n\t\t\t\t\t\t<mat-option value=\"Info\">Info</mat-option>\n\t\t\t\t\t\t<mat-option value=\"\">None (info)</mat-option>\n\t\t\t\t\t</mat-select>\n\t\t\t\t</mat-form-field>\n\t\t\t\t<mat-form-field appearance=\"fill\" color=\"accent\">\n\t\t\t\t\t<mat-label>Action</mat-label>\n\t\t\t\t\t<input type=\"text\" placeholder=\"Action\" matInput formControlName=\"action\" />\n\t\t\t\t</mat-form-field>\n\t\t\t\t<!-- attachement -->\n\t\t\t\t<div formGroupName=\"config\">\n\t\t\t\t\t<mat-form-field appearance=\"fill\" color=\"accent\">\n\t\t\t\t\t\t<mat-label>Duration</mat-label>\n\t\t\t\t\t\t<input type=\"number\" placeholder=\"Duration\" matInput formControlName=\"duration\" />\n\t\t\t\t\t</mat-form-field>\n\t\t\t\t\t<mat-form-field appearance=\"fill\" color=\"accent\" class=\"width-100\" subscriptSizing=\"dynamic\">\n\t\t\t\t\t\t<mat-label>Horizontal Position</mat-label>\n\t\t\t\t\t\t<mat-select formControlName=\"horizontalPosition\">\n\t\t\t\t\t\t\t<mat-option value=\"start\">Start</mat-option>\n\t\t\t\t\t\t\t<mat-option value=\"center\">Center</mat-option>\n\t\t\t\t\t\t\t<mat-option value=\"end\">End</mat-option>\n\t\t\t\t\t\t\t<mat-option value=\"left\">Left</mat-option>\n\t\t\t\t\t\t\t<mat-option value=\"right\">Right</mat-option>\n\t\t\t\t\t\t</mat-select>\n\t\t\t\t\t</mat-form-field>\n\t\t\t\t\t<mat-form-field appearance=\"fill\" color=\"accent\" class=\"width-100\" subscriptSizing=\"dynamic\">\n\t\t\t\t\t\t<mat-label>Vertical Position</mat-label>\n\t\t\t\t\t\t<mat-select formControlName=\"verticalPosition\">\n\t\t\t\t\t\t\t<mat-option value=\"top\">Top</mat-option>\n\t\t\t\t\t\t\t<mat-option value=\"bottom\">Bottom</mat-option>\n\t\t\t\t\t\t</mat-select>\n\t\t\t\t\t</mat-form-field>\n\t\t\t\t</div>\n\t\t\t</form>\n\t\t\t<button mat-flat-button color=\"accent\" (click)=\"showAlert()\">show alert</button>\n\t\t</mat-dialog-content>\n\t\t<mat-dialog-actions align=\"end\">\n\t\t\t<button mat-stroked-button mat-dialog-close>Close</button>\n\t\t</mat-dialog-actions>\n\t`,\n\tstyles: ``\n})\nexport class TestAlertComponent {\n\tpublic data = inject(MAT_DIALOG_DATA);\n\t// private dialogRef: MatDialogRef<TestAlertComponent>;\n\tprivate fb: any = inject(FormBuilder);\n\tprivate _alertService: any = inject(AlertService);\n\n\tpublic form: FormGroup = this.fb.group({\n\t\tmessage: ['Here is a test message.'],\n\t\tsnackType: [''],\n\t\taction: [''],\n\t\tconfig: this.fb.group({\n\t\t\tduration: [5000],\n\t\t\thorizontalPosition: ['center'],\n\t\t\tverticalPosition: ['bottom']\n\t\t})\n\t});\n\n\tpublic showAlert() {\n\t\tthis._alertService.addAlert(this.form.value);\n\t}\n}\n"
    }
}


[Trace - 1:01:08 PM] Received notification 'angular/projectLoadingStart'.
Params: [
    null
]


[Trace - 1:01:08 PM] Sending request 'angular/isAngularCoreInOwningProject - (1)'.
Params: {
    "textDocument": {
        "uri": "file:///app/ui/src/app/modules/admin/admin.module.ts"
    }
}


[Trace - 1:01:08 PM] Sending request 'textDocument/codeLens - (2)'.
Params: {
    "textDocument": {
        "uri": "file:///app/ui/src/app/modules/admin/admin.module.ts"
    }
}


[Trace - 1:01:09 PM] Received notification 'angular/projectLoadingFinish'.
Params: [
    null
]


[Trace - 1:01:09 PM] Received notification 'window/logMessage'.
Params: {
    "type": 3,
    "message": "Enabling language service for /app/ui/tsconfig.json."
}


[Info  - 1:01:09 PM] Enabling language service for /app/ui/tsconfig.json.
[Trace - 1:01:09 PM] Received response 'angular/isAngularCoreInOwningProject - (1)' in 1074ms.
Result: true


[Trace - 1:01:09 PM] Sending request 'textDocument/foldingRange - (3)'.
Params: {
    "textDocument": {
        "uri": "file:///app/ui/src/app/modules/admin/admin.module.ts"
    }
}


[Trace - 1:01:09 PM] Received response 'textDocument/codeLens - (2)' in 1027ms.
No result returned.


[Trace - 1:01:09 PM] Received response 'textDocument/foldingRange - (3)' in 1ms.
Result: []


[Trace - 1:01:09 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///app/ui/src/app/modules/admin/components/test-alert/test-alert.component.ts",
    "diagnostics": []
}


[Trace - 1:01:09 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///app/ui/src/app/modules/admin/admin.module.ts",
    "diagnostics": [
        {
            "range": {
                "start": {
                    "line": 12,
                    "character": 16
                },
                "end": {
                    "line": 12,
                    "character": 34
                }
            },
            "message": "Component TestAlertComponent is standalone, and cannot be declared in an NgModule. Did you mean to import it instead?",
            "severity": 1,
            "code": -996008
        },
        {
            "range": {
                "start": {
                    "line": 12,
                    "character": 36
                },
                "end": {
                    "line": 12,
                    "character": 50
                }
            },
            "message": "Component AdminComponent is standalone, and cannot be declared in an NgModule. Did you mean to import it instead?",
            "severity": 1,
            "code": -996008
        },
        {
            "range": {
                "start": {
                    "line": 12,
                    "character": 52
                },
                "end": {
                    "line": 12,
                    "character": 76
                }
            },
            "message": "Component RolePermissionsComponent is standalone, and cannot be declared in an NgModule. Did you mean to import it instead?",
            "severity": 1,
            "code": -996008
        },
        {
            "range": {
                "start": {
                    "line": 12,
                    "character": 78
                },
                "end": {
                    "line": 12,
                    "character": 107
                }
            },
            "message": "Component RolePermissionDialogComponent is standalone, and cannot be declared in an NgModule. Did you mean to import it instead?",
            "severity": 1,
            "code": -996008
        }
    ]
}

[RajSimcorp]

I am also getting error after updating latest angular language service extension.

Component DialogComponent is standalone, and cannot be declared in an NgModule. Did you mean to import it instead?(-996008)
(alias) class DialogComponent
import DialogComponent

Though my component is not a standalone.
Adding standalone: false to component decorator solves issue.

My current angular version is 17.3.0

"dependencies": {
    "@angular/animations": "^17.3.0",
    "@angular/common": "^17.3.0",
    "@angular/compiler": "^17.3.0",
    "@angular/core": "^17.3.0",
    "@angular/forms": "^17.3.0",
    "@angular/material": "^17.3.0",
    "@angular/platform-browser": "^17.3.0",
    "@angular/platform-browser-dynamic": "^17.3.0",
    "@angular/router": "^17.3.0",
    "@ngrx/store":"^17.2.0",
    "@ngrx/effects":"^17.2.0",
    "@ngrx/component-store":"^17.2.0",
    "@ngrx/component": "^17.2.0",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "~0.14.3"
},
"devDependencies": {
    "@angular-devkit/build-angular": "^17.3.0",
    "@angular/cli": "^17.3.0",
    "@angular/compiler-cli": "^17.3.0",
    "@types/jasmine": "~5.1.0",
    "jasmine-core": "~5.1.0",
    "karma": "~6.4.0",
    "karma-chrome-launcher": "~3.2.0",
    "karma-coverage": "~2.2.0",
    "karma-jasmine": "~5.1.0",
    "karma-jasmine-html-reporter": "~2.1.0",
    "ng-packagr": "^17.2.0",
    "npm-run-all": "^4.1.5",
    "typescript": "~5.4.2"
}

[devversion]

Should be fixed via 6692c40. Can you please verify and re-comment?

[invaderb]

Fixed on my end after installing the update! Thanks for pushing a fix so fast.

[devversion]

thanks for verifying and reporting the issue!

[DallasHoff]

Yep, working now. Thank you!

[RajSimcorp]

Its working now. Thanks

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}