refactor(file): effectify FileService as scoped service#17678
Closed
kitlangton wants to merge 3 commits intoeffectify-formatfrom
Closed
refactor(file): effectify FileService as scoped service#17678kitlangton wants to merge 3 commits intoeffectify-formatfrom
kitlangton wants to merge 3 commits intoeffectify-formatfrom
Conversation
kitlangton
force-pushed
the
effectify-file
branch
from
a99695b to
81e2a7a
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
81e2a7a to
9d3560c
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
56d5cb3 to
f173504
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
5b6ea84 to
2dd6279
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
f173504 to
07c391f
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
2dd6279 to
01e301e
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
07c391f to
004542d
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
01e301e to
63d3b5c
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
004542d to
ac9ff7a
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
ac9ff7a to
9d70289
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
63d3b5c to
08eb184
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
9d70289 to
2f36dd1
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
08eb184 to
13b5056
Compare
kitlangton
force-pushed
the
effectify-format
branch
from
2f36dd1 to
363bc0c
Compare
Cover previously untested File service functions: status() with modified/untracked/deleted/binary files, list() with sorting/filtering/ gitignore/security, search() with fuzzy matching/type filters/limits, and read() git diff/patch code paths.
Convert File namespace functions (init, status, read, list, search) to FileService class extending ServiceMap.Service with Effect.fn methods. File cache uses lazy initialization via init() matching original Instance.state semantics. Legacy promise facade preserved.
kitlangton
force-pushed
the
effectify-file
branch
from
13b5056 to
577f9c2
Compare
This was referenced Mar 16, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filenamespace functions (init,status,read,list,search) toFileServiceclass extendingServiceMap.ServicewithEffect.fnmethodsinit()matching originalInstance.statesemantics — production bootstrapper callsinit()immediately, tests only pay for Ripgrep scanning when they opt inrunPromiseInstanceFileServiceinInstanceslayer maplist()subdirectory testTest plan
Stack
effectify-format(open)effectify-format(open)effectify-skill(open)effectify-format-> refactor(file): effectify FileService as scoped service #17678effectify-file-> refactor(skill): effectify SkillService as scoped service #17810effectify-skill