refactor(file): effectify FileService as scoped service#17845
Merged
kitlangton merged 3 commits intodevfrom Mar 16, 2026
Merged
refactor(file): effectify FileService as scoped service#17845kitlangton merged 3 commits intodevfrom
kitlangton merged 3 commits intodevfrom
Conversation
Cover previously untested File service functions: status() with modified/untracked/deleted/binary files, list() with sorting/filtering/ gitignore/security, search() with fuzzy matching/type filters/limits, and read() git diff/patch code paths.
Convert File namespace functions (init, status, read, list, search) to FileService class extending ServiceMap.Service with Effect.fn methods. File cache uses lazy initialization via init() matching original Instance.state semantics. Legacy promise facade preserved.
3 tasks
3 tasks
ConanXu-math
pushed a commit
to ConanXu-math/opencode
that referenced
this pull request
Mar 17, 2026
3 tasks
AvatarGanymede
pushed a commit
to AvatarGanymede/opencode-dev
that referenced
this pull request
Mar 19, 2026
demostanis
pushed a commit
to demostanis/opencode
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filenamespace functions (init,status,read,list,search) toFileServiceclass extendingServiceMap.ServicewithEffect.fnmethodsinit()matching originalInstance.statesemantics — production bootstrapper callsinit()immediately, tests only pay for Ripgrep scanning when they opt inrunPromiseInstanceFileServiceinInstanceslayer maplist()subdirectory testTest plan
Restacked from #17678 onto
devafter parent merge.Stack
Base:
devCurrent / Remaining
effectify-file- currenteffectify-skill