refactor(skill): effectify SkillService as scoped service#17810
Closed
kitlangton wants to merge 1 commit intoeffectify-filefrom
Closed
refactor(skill): effectify SkillService as scoped service#17810kitlangton wants to merge 1 commit intoeffectify-filefrom
kitlangton wants to merge 1 commit intoeffectify-filefrom
Conversation
kitlangton
force-pushed
the
effectify-skill
branch
2 times, most recently
from
1ff5330 to
a9a6be3
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
5b6ea84 to
2dd6279
Compare
kitlangton
force-pushed
the
effectify-skill
branch
from
a9a6be3 to
47ec969
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
2dd6279 to
01e301e
Compare
kitlangton
force-pushed
the
effectify-skill
branch
from
47ec969 to
5a7cb74
Compare
kitlangton
force-pushed
the
effectify-file
branch
from
01e301e to
63d3b5c
Compare
kitlangton
force-pushed
the
effectify-skill
branch
from
5a7cb74 to
f2ef3c2
Compare
kitlangton
force-pushed
the
effectify-file
branch
3 times, most recently
from
13b5056 to
577f9c2
Compare
kitlangton
force-pushed
the
effectify-skill
branch
from
f2ef3c2 to
33e8d96
Compare
This was referenced Mar 16, 2026
kitlangton
force-pushed
the
effectify-file
branch
from
577f9c2 to
26b0a43
Compare
4 tasks
Convert Skill namespace to SkillService class with Effect.fn methods. Scanning runs eagerly in layer constructor — needs lazy init to avoid breaking unrelated tests (same pattern as FileService).
kitlangton
force-pushed
the
effectify-skill
branch
from
33e8d96 to
06f620a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skillnamespace toSkillServiceclass extendingServiceMap.ServicewithEffect.fnmethodsensureScanned()promise memoization — scan runs on firstget/all/dirs/availablecall, not in layer constructorimport("@/session")in error handler to break circular dep (instances.ts→skill.ts→@/session→@/tool)runPromiseInstancefmt()stays on theSkillnamespace (no state needed)Test plan
Stack
Base:
devMerged
effectify-fileCurrent / Remaining
2. #17810
effectify-skill- current