refactor(skill): effectify SkillService as scoped service#17849
Merged
kitlangton merged 3 commits intodevfrom Mar 16, 2026
Merged
refactor(skill): effectify SkillService as scoped service#17849kitlangton merged 3 commits intodevfrom
kitlangton merged 3 commits intodevfrom
Conversation
Convert Skill namespace to SkillService class with Effect.fn methods. Scanning runs eagerly in layer constructor — needs lazy init to avoid breaking unrelated tests (same pattern as FileService).
kitlangton
force-pushed
the
effectify-skill
branch
from
06f620a to
527956e
Compare
ConanXu-math
pushed a commit
to ConanXu-math/opencode
that referenced
this pull request
Mar 17, 2026
3 tasks
AvatarGanymede
pushed a commit
to AvatarGanymede/opencode-dev
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skillnamespace toSkillServiceclass extendingServiceMap.ServicewithEffect.fnmethodsensureScanned()promise memoization — scan runs on firstget/all/dirs/availablecall, not in layer constructorimport("@/session")in error handler to break circular dep (instances.ts→skill.ts→@/session→@/tool)runPromiseInstancefmt()stays on theSkillnamespace (no state needed)Test plan
Restacked from #17810 onto
devafter parent merge.Stack
Base:
devCurrent / Remaining
effectify-skill- current