fix: only slash-escape HTML tag angle brackets outside of code sections#322
Closed
markjaquith wants to merge 3 commits into
Closed
fix: only slash-escape HTML tag angle brackets outside of code sections#322markjaquith wants to merge 3 commits into
markjaquith wants to merge 3 commits into
Conversation
markjaquith
changed the title
Member
|
my only pause is that i wonder if this problem just goes away if we stop formatting user messages as markdown? assistant messages don't have this problem, right? |
Contributor
Author
|
Assistant messages do have the problem:
|
Contributor
Author
|
Maybe instead of rendering assistant messages as markdown and then trying to slash-escape angle brackets that aren't in code blocks, you should just specifically look for inline code and code blocks to highlight and pass the rest through unadulterated. |
Contributor
Author
|
Issue got fixed at some point, although at the expense of re-enabling the bug where HTML that is not code-fenced is invisible. |
bussard76
pushed a commit
to bussard76/openwork
that referenced
this pull request
May 12, 2026
bussard76
pushed a commit
to bussard76/openwork
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #320
Added unit tests because this is the kind of twitchy text-parsing that really benefits from it.
What I don't know is if there is a better library to use that can do the "are we in a code block" parsing in a definitely-spec-compliant way. This way is pretty brute force and naive.